Avoid looking up absent cells in rangeResolver
#2111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
While benchmarking the performance of
SUMIFS
I've discovered that when a range references an entire column or an entire row, excelize scans the entire theoretical range even if the file is smaller than that. This was already discovered by #2056.Description
I've initially tried to reduce the scan range, but a lot of the code assume that
rangeResolver
is going to be scanning the entire range, so I've changed it to instead skip looking up cells that don't exist.Related Issue
#2056
Motivation and Context
This makes a big performance difference.
How Has This Been Tested
I've run tests and also tested this on my projects.
Types of changes
Checklist
PR developed together with @Aprax14.