Skip to content

feat: switch from eslint-plugin-node to eslint-plugin-n #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

feat: switch from eslint-plugin-node to eslint-plugin-n #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 83 additions & 97 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"eslint-plugin-github": "^5.1.8",
"eslint-plugin-import": "^2.31.0",
"eslint-plugin-jest": "^28.11.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-n": "^17.18.0",
"eslint-plugin-perfectionist": "^4.11.0",
"eslint-plugin-promise": "^7.2.1",
"eslint-plugin-react-compiler": "^19.0.0-beta-e993439-20250405",
Expand Down
2 changes: 1 addition & 1 deletion src/config/disabled.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const disabledRulesFromPresets = {

// no-missing-import requires a lot of manual configuration,
// and we already have TypeScript to catch missing imports
"node/no-missing-import": "off",
"n/no-missing-import": "off",

"promise/always-return": "off",
"promise/no-callback-in-promise": "off",
Expand Down
2 changes: 1 addition & 1 deletion src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const main = {
"plugin:jest/recommended",
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:node/recommended",
"plugin:n/recommended",
"plugin:promise/recommended",
"plugin:react/recommended",
"plugin:react-hooks/recommended",
Expand Down
4 changes: 2 additions & 2 deletions src/config/other.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,10 @@ export const otherRules = {
],
"no-throw-literal": "error",

"node/no-unsupported-features/es-syntax": [
"n/no-unsupported-features/es-syntax": [
"error",
{
// https://github.com/mysticatea/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-syntax.md#ignores
// https://github.com/eslint-community/eslint-plugin-n/blob/HEAD/docs/rules/no-unsupported-features/es-syntax.md#ignores
ignores: ["dynamicImport", "modules"],
},
],
Expand Down
2 changes: 1 addition & 1 deletion src/config/overrides.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const overrides = [
"@typescript-eslint/no-non-null-assertion": "off",

// Allow test files to use dev dependencies
"node/no-unpublished-import": "off",
"n/no-unpublished-import": "off",
},
},
{
Expand Down