Code Style

lib/Qandidate/Toggle/Operator/GreaterThan.php

@@ -15,7 +15,8 @@
 
 /**
  * @template T
- * @template-extends EqualityOperator<T> 
+ *
+ * @template-extends EqualityOperator<T>
  */
 class GreaterThan extends EqualityOperator
 {

lib/Qandidate/Toggle/Operator/GreaterThanEqual.php

@@ -15,7 +15,8 @@
 
 /**
  * @template T
- * @template-extends EqualityOperator<T> 
+ *
+ * @template-extends EqualityOperator<T>
  */
 class GreaterThanEqual extends EqualityOperator
 {

lib/Qandidate/Toggle/Operator/HasIntersection.php

@@ -13,11 +13,9 @@
 
 namespace Qandidate\Toggle\Operator;
 
-use InvalidArgumentException;
-
-
 /**
  * @template T
+ *
  * @template-extends EqualityOperator<T>
  */
 class HasIntersection extends EqualityOperator
@@ -32,7 +30,7 @@ public function __construct(private readonly array $values)
     public function appliesTo(mixed $argument): bool
     {
         if (!is_array($argument)) {
-            throw new InvalidArgumentException('HasIntersection can only be compared against array values');
+            throw new \InvalidArgumentException('HasIntersection can only be compared against array values');
         }
 
         return null !== $argument

lib/Qandidate/Toggle/Operator/LessThan.php

@@ -15,7 +15,8 @@
 
 /**
  * @template T
- * @template-extends EqualityOperator<T> 
+ *
+ * @template-extends EqualityOperator<T>
  */
 class LessThan extends EqualityOperator
 {

lib/Qandidate/Toggle/Operator/LessThanEqual.php

@@ -15,7 +15,8 @@
 
 /**
  * @template T
- * @template-extends EqualityOperator<T> 
+ *
+ * @template-extends EqualityOperator<T>
  */
 class LessThanEqual extends EqualityOperator
 {

lib/Qandidate/Toggle/Operator/MatchesRegex.php

@@ -13,18 +13,15 @@
 
 namespace Qandidate\Toggle\Operator;
 
-use InvalidArgumentException;
-
-
 /**
- * @template-extends EqualityOperator<string> 
+ * @template-extends EqualityOperator<string>
  */
 class MatchesRegex extends EqualityOperator
 {
     public function appliesTo(mixed $argument): bool
     {
         if (!is_string($argument)) {
-            throw new InvalidArgumentException('MatchesRegex can only be matched against strings');
+            throw new \InvalidArgumentException('MatchesRegex can only be matched against strings');
         }
 
         return (bool) preg_match($this->value, $argument);

lib/Qandidate/Toggle/Operator/NotInSet.php

@@ -15,6 +15,7 @@
 
 /**
  * @template T
+ *
  * @extends InSet<T>
  */
 class NotInSet extends InSet

lib/Qandidate/Toggle/Operator/Percentage.php

@@ -13,7 +13,6 @@
 
 namespace Qandidate\Toggle\Operator;
 
-use InvalidArgumentException;
 use Qandidate\Toggle\Operator;
 
 class Percentage implements Operator
@@ -25,7 +24,7 @@ public function __construct(private readonly int $percentage, private readonly i
     public function appliesTo(mixed $argument): bool
     {
         if (!is_int($argument)) {
-            throw new InvalidArgumentException('Percentage only accepts integers');
+            throw new \InvalidArgumentException('Percentage only accepts integers');
         }
 
         $asPercentage = (int) $argument % 100;

lib/Qandidate/Toggle/Serializer/OperatorConditionSerializer.php

@@ -13,7 +13,6 @@
 
 namespace Qandidate\Toggle\Serializer;
 
-use RuntimeException;
 use Qandidate\Toggle\OperatorCondition;
 
 /**
@@ -41,7 +40,7 @@ public function deserialize(array $condition): OperatorCondition
         $this->assertHasKey('operator', $condition);
 
         if ('operator-condition' !== $condition['name']) {
-            throw new RuntimeException(sprintf('Unable to deserialize operator with name "%s".', $condition['name']));
+            throw new \RuntimeException(sprintf('Unable to deserialize operator with name "%s".', $condition['name']));
         }
 
         $operator = $this->operatorSerializer->deserialize($condition['operator']);
@@ -52,7 +51,7 @@ public function deserialize(array $condition): OperatorCondition
     private function assertHasKey(string $key, array $data): void
     {
         if (!array_key_exists($key, $data)) {
-            throw new RuntimeException(sprintf('Missing key "%s" in data.', $key));
+            throw new \RuntimeException(sprintf('Missing key "%s" in data.', $key));
         }
     }
 }

lib/Qandidate/Toggle/Serializer/OperatorSerializer.php

@@ -13,7 +13,6 @@
 
 namespace Qandidate\Toggle\Serializer;
 
-use RuntimeException;
 use Qandidate\Toggle\Operator;
 use Qandidate\Toggle\Operator\EqualTo;
 use Qandidate\Toggle\Operator\GreaterThan;
@@ -55,7 +54,7 @@ public function serialize(Operator $operator): array
             case MatchesRegex::class:
                 return ['name' => 'matches-regex', 'value' => $operator->getValue()];
             default:
-                throw new RuntimeException(sprintf('Unknown operator %s.', $operator::class));
+                throw new \RuntimeException(sprintf('Unknown operator %s.', $operator::class));
         }
     }
 
@@ -107,14 +106,14 @@ public function deserialize(array $operator): Operator
 
                 return new MatchesRegex($operator['value']);
             default:
-                throw new RuntimeException(sprintf('Unknown operator with name "%s".', $operator['name']));
+                throw new \RuntimeException(sprintf('Unknown operator with name "%s".', $operator['name']));
         }
     }
 
     private function assertHasKey(string $key, array $data): void
     {
         if (!array_key_exists($key, $data)) {
-            throw new RuntimeException(sprintf('Missing key "%s" in data.', $key));
+            throw new \RuntimeException(sprintf('Missing key "%s" in data.', $key));
         }
     }
 }

lib/Qandidate/Toggle/Serializer/ToggleSerializer.php

@@ -13,8 +13,6 @@
 
 namespace Qandidate\Toggle\Serializer;
 
-use RuntimeException;
-use InvalidArgumentException;
 use Qandidate\Toggle\OperatorCondition;
 use Qandidate\Toggle\Toggle;
 
@@ -43,7 +41,7 @@ public function deserialize(array $data): Toggle
         $this->assertHasKey('conditions', $data);
 
         if (!is_array($data['conditions'])) {
-            throw new RuntimeException('Key "conditions" should be an array.');
+            throw new \RuntimeException('Key "conditions" should be an array.');
         }
 
         $toggle = new Toggle(
@@ -65,7 +63,7 @@ private function serializeConditions(array $conditions): array
 
         foreach ($conditions as $condition) {
             if (!$condition instanceof OperatorCondition) {
-                throw new RuntimeException(sprintf('Unable to serialize %s.', $condition::class));
+                throw new \RuntimeException(sprintf('Unable to serialize %s.', $condition::class));
             }
 
             $serialized[] = $this->operatorConditionSerializer->serialize($condition);
@@ -91,7 +89,7 @@ private function serializeStatus(Toggle $toggle): string
             Toggle::ALWAYS_ACTIVE => 'always-active',
             Toggle::INACTIVE => 'inactive',
             Toggle::CONDITIONALLY_ACTIVE => 'conditionally-active',
-            default => throw new InvalidArgumentException('unsupported status'),
+            default => throw new \InvalidArgumentException('unsupported status'),
         };
     }
 
@@ -112,7 +110,7 @@ private function deserializeStatus(Toggle $toggle, string $status): void
                 return;
         }
 
-        throw new RuntimeException(sprintf('Unknown toggle status "%s".', $status));
+        throw new \RuntimeException(sprintf('Unknown toggle status "%s".', $status));
     }
 
     private function serializeStrategy(Toggle $toggle): string
@@ -121,7 +119,7 @@ private function serializeStrategy(Toggle $toggle): string
             Toggle::STRATEGY_AFFIRMATIVE => 'affirmative',
             Toggle::STRATEGY_MAJORITY => 'majority',
             Toggle::STRATEGY_UNANIMOUS => 'unanimous',
-            default => throw new InvalidArgumentException('unsupported strategy'),
+            default => throw new \InvalidArgumentException('unsupported strategy'),
         };
     }
 
@@ -131,14 +129,14 @@ private function deserializeStrategy(string $strategy): int
             'affirmative' => Toggle::STRATEGY_AFFIRMATIVE,
             'majority' => Toggle::STRATEGY_MAJORITY,
             'unanimous' => Toggle::STRATEGY_UNANIMOUS,
-            default => throw new RuntimeException(sprintf('Unknown toggle strategy "%s".', $strategy)),
+            default => throw new \RuntimeException(sprintf('Unknown toggle strategy "%s".', $strategy)),
         };
     }
 
     private function assertHasKey(string $key, array $data): void
     {
         if (!array_key_exists($key, $data)) {
-            throw new RuntimeException(sprintf('Missing key "%s" in data.', $key));
+            throw new \RuntimeException(sprintf('Missing key "%s" in data.', $key));
         }
     }
 }

lib/Qandidate/Toggle/Toggle.php

@@ -13,7 +13,6 @@
 
 namespace Qandidate\Toggle;
 
-use InvalidArgumentException;
 /**
  * Representation of a feature toggle.
  *
@@ -110,7 +109,7 @@ public function getStrategy(): int
     private function assertValidActiveStatus(int $status): void
     {
         if (self::ALWAYS_ACTIVE !== $status && self::CONDITIONALLY_ACTIVE !== $status) {
-            throw new InvalidArgumentException('No "active" status was provided.');
+            throw new \InvalidArgumentException('No "active" status was provided.');
         }
     }
 
@@ -121,7 +120,7 @@ private function assertValidStrategy(int $strategy): void
             self::STRATEGY_MAJORITY,
             self::STRATEGY_UNANIMOUS,
         ])) {
-            throw new InvalidArgumentException('No supported strategy was provided.');
+            throw new \InvalidArgumentException('No supported strategy was provided.');
         }
     }
 

lib/Qandidate/Toggle/ToggleManager.php

@@ -13,8 +13,6 @@
 
 namespace Qandidate\Toggle;
 
-use RuntimeException;
-use InvalidArgumentException;
 /**
  * Manages the toggles of an application.
  */
@@ -63,18 +61,18 @@ public function update(Toggle $toggle): void
     /**
      * Rename the toggle.
      *
-     * @throws RuntimeException
+     * @throws \RuntimeException
      */
     public function rename(string $oldName, string $newName): void
     {
         if ($this->collection->get($newName) instanceof Toggle) {
-            throw new RuntimeException(sprintf('Could not rename toggle %1$s to %2$s, a toggle with name %2$s already exists', $oldName, $newName));
+            throw new \RuntimeException(sprintf('Could not rename toggle %1$s to %2$s, a toggle with name %2$s already exists', $oldName, $newName));
         }
 
         $currentToggle = $this->collection->get($oldName);
 
         if (!$currentToggle instanceof Toggle) {
-            throw new RuntimeException(sprintf('Could not rename toggle %1$s to %2$s, toggle with name %1$s does not exists', $oldName, $newName));
+            throw new \RuntimeException(sprintf('Could not rename toggle %1$s to %2$s, toggle with name %1$s does not exists', $oldName, $newName));
         }
 
         $currentToggle->rename($newName);
@@ -94,13 +92,13 @@ public function all(): array
     /**
      * @return Toggle toggle from manager that has given name
      *
-     * @throws InvalidArgumentException
+     * @throws \InvalidArgumentException
      */
     public function get(string $name): Toggle
     {
         $toggle = $this->collection->get($name);
         if (!$toggle instanceof Toggle) {
-            throw new InvalidArgumentException("Cannot find Toggle with name $name");
+            throw new \InvalidArgumentException("Cannot find Toggle with name $name");
         }
 
         return $toggle;

rector.php

@@ -13,6 +13,7 @@
     ]);
 
     $rectorConfig->importNames();
+    $rectorConfig->importShortClasses(false);
 
     $rectorConfig->sets([
         LevelSetList::UP_TO_PHP_81,

test/Qandidate/Toggle/ExpressionConditionTest.php

@@ -13,8 +13,8 @@
 
 namespace Qandidate\Toggle;
 
-use Symfony\Component\ExpressionLanguage\SyntaxError;
 use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
+use Symfony\Component\ExpressionLanguage\SyntaxError;
 
 class ExpressionConditionTest extends TestCase
 {

test/Qandidate/Toggle/ToggleCollection/PredisCollectionTest.php

@@ -42,7 +42,7 @@ public function tearDown(): void
         }
     }
 
-    public function createCollection()
+    public function createCollection(): PredisCollection
     {
         return $this->collection;
     }