Skip to content

test: add action guard invalid tool-call coverage #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
northline-lab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add action guard invalid tool-call coverage #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions tests/unit/test_provider_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,74 @@ def test_rejects_missing_required_tool_argument(self) -> None:
self.assertEqual("invalid_tool_arguments", payload["recovery_kind"])
self.assertIn("missing required argument", payload["message"])

def test_rejects_unknown_tool_call(self) -> None:
response = _model_response([_tool_call("unknown_tool", {"path": "repo/app.py"})])

guarded = guard_model_response(response, [_sample_tool, _recovery_tool])

recovery = guarded.output[0]
self.assertIsInstance(recovery, ResponseFunctionToolCall)
payload = json.loads(recovery.arguments)
self.assertEqual("unknown_tool", payload["recovery_kind"])
self.assertEqual("unknown_tool", payload["attempted_tool"])
self.assertIn("Rejected unknown tool call", payload["message"])

def test_rejects_malformed_tool_arguments_json(self) -> None:
response = _model_response(
[
ResponseFunctionToolCall(
arguments="{not json",
call_id="call-sample_tool",
name="sample_tool",
type="function_call",
)
]
)

guarded = guard_model_response(response, [_sample_tool, _recovery_tool])

recovery = guarded.output[0]
self.assertIsInstance(recovery, ResponseFunctionToolCall)
payload = json.loads(recovery.arguments)
self.assertEqual("malformed_action", payload["recovery_kind"])
self.assertEqual("sample_tool", payload["attempted_tool"])
self.assertIn("malformed JSON arguments", payload["message"])

def test_rejects_non_object_tool_arguments_json(self) -> None:
response = _model_response(
[
ResponseFunctionToolCall(
arguments=json.dumps(["repo/app.py"]),
call_id="call-sample_tool",
name="sample_tool",
type="function_call",
)
]
)

guarded = guard_model_response(response, [_sample_tool, _recovery_tool])

recovery = guarded.output[0]
self.assertIsInstance(recovery, ResponseFunctionToolCall)
payload = json.loads(recovery.arguments)
self.assertEqual("invalid_tool_arguments", payload["recovery_kind"])
self.assertEqual("sample_tool", payload["attempted_tool"])
self.assertIn("non-object arguments", payload["message"])

def test_rejects_unexpected_tool_argument(self) -> None:
response = _model_response(
[_tool_call("sample_tool", {"path": "repo/app.py", "extra": "unused"})]
)

guarded = guard_model_response(response, [_sample_tool, _recovery_tool])

recovery = guarded.output[0]
self.assertIsInstance(recovery, ResponseFunctionToolCall)
payload = json.loads(recovery.arguments)
self.assertEqual("invalid_tool_arguments", payload["recovery_kind"])
self.assertEqual("sample_tool", payload["attempted_tool"])
self.assertIn("unexpected argument(s) extra", payload["message"])

def test_recovery_tool_call_ids_are_unique(self) -> None:
response = _model_response([_tool_call("sample_tool", {})])

Expand Down