test: add unit tests for contribarena.models.agent_result Pydantic models#125
Open
northline-lab wants to merge 1 commit into
Open
Conversation
…dels ## Summary Add focused unit tests for `contribarena.models.agent_result` Pydantic models that previously had no dedicated test coverage. ## Models now tested | Model | Purpose | |---|---| | `RepoSummary` | Captures repository identity (owner, name, url, default_branch) | | `OpportunitySummary` | Describes a contribution opportunity with risk level | | `SelectedTask` | Describes the selected task with risk level | | `WorkspaceSummary` | Captures workspace commands and patch status | | `AgentFinalResult` | Top-level agent run result with nested models | ## Test Coverage - **RepoSummaryTest** (6 tests) — required fields, defaults, explicit values, missing fields raise ValidationError - **OpportunitySummaryTest** (6 tests) — required fields, defaults, explicit values, all risk literals accepted, invalid risk rejected, missing title raises - **SelectedTaskTest** (6 tests) — required fields, defaults, explicit values, all risk literals accepted, invalid risk rejected, missing title raises - **WorkspaceSummaryTest** (3 tests) — defaults, explicit values with CommandResult, commands_run factory independence - **AgentFinalResultTest** (11 tests) — required fields, all status literals accepted, invalid status rejected, defaults, explicit values with nested models, blockers factory independence, missing required fields raise, dict-input coercion for nested repo and task - **AgentResultImportTest** (1 test) — all 5 symbols importable from contribarena.models package No production code is modified. ## Verification - `pytest -q tests/unit/test_agent_result_models.py` → 33 passed in 0.20s - `ruff check tests/unit/test_agent_result_models.py` → All checks passed - No secrets in diff ## Risk Low — test-only addition. No production code is modified. --- *Prepared by ContribArena in owned-live mode.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add focused unit tests for
contribarena.models.agent_resultPydantic models that previously had no dedicated test coverage.Models now tested
RepoSummaryOpportunitySummarySelectedTaskWorkspaceSummaryAgentFinalResultTest Coverage
No production code is modified.
Verification
pytest -q tests/unit/test_agent_result_models.py→ 33 passed in 0.20sruff check tests/unit/test_agent_result_models.py→ All checks passedRisk
Low — test-only addition. No production code is modified.
Prepared by ContribArena in owned-live mode.