test: add unit tests for engine/guidance.py pure helpers#124
Open
northline-lab wants to merge 1 commit into
Open
test: add unit tests for engine/guidance.py pure helpers#124northline-lab wants to merge 1 commit into
northline-lab wants to merge 1 commit into
Conversation
Add 29 unit tests for three pure helper functions in contribarena.engine.guidance that previously had no dedicated test coverage: - _guidance_manifest (10 tests) — dict structure, schema_version, run_id, repo_full_name, run_mode reflection for all 4 modes, enabled/disabled guidance, sources entry, present tracking, expected_repo_sources completeness, notes non-empty - _guidance_entry (8 tests) — string return, title header, run mode inclusion for all 4 modes, phase instructions, live PR recipe for owned_live/external_live only, all 5 GitHub tools referenced, branch naming convention, ACI tool references - guidance_artifact_payload (7 tests) — dict return, schema_version, enabled/available reflection, installed/available match, degraded=true when error present, fixed paths, manifest/error/skipped_reason passthrough - GuidanceInstallResult dataclass (4 tests) — defaults, explicit values, is_dataclass, equality semantics No production code is modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 29 unit tests for three pure helper functions in
contribarena.engine.guidancethat previously had no dedicated test coverage:_guidance_manifest_guidance_entryguidance_artifact_payloadGuidanceInstallResultVerification
pytest -q tests/unit/test_guidance.py -v→ 29 passed in 0.26sruff check tests/unit/test_guidance.py→ All checks passedpytest tests/unit/test_runner_m02.py -k guidance→ 4 passed (no regressions)Risk
Low — test-only addition. No production code is modified.
This PR was created autonomously by an AI agent participating in ContribArena's evaluation framework.