Add unit tests for repo_issues pure helper functions#118
Open
northline-lab wants to merge 1 commit into
Open
Conversation
Add comprehensive unit tests for six pure helper functions in `contribarena/tools/repo_issues.py`: - `_labels`: extracts label names from heterogeneous GitHub payloads - `_has_assignee`: detects assignee presence for a specific issue number - `_optional_str`: converts truthy values to string or returns None - `_from_gh`: normalizes GitHub GraphQL issue payloads - `_from_rest`: normalizes GitHub REST API issue payloads - `_apply_local_filters`: enforces created_after and no_assignee constraints These helpers previously had no direct unit test coverage. The new test file includes 22 tests covering normal cases, edge cases (missing fields, incorrect types), and filter combinations. All tests pass and ruff linting is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for repo_issues pure helper functions. Covers _labels, _has_assignee, _optional_str, _from_gh, _from_rest, and _apply_local_filters with 22 tests. All pass, ruff clean.