update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to #130459 It adds a test for - `examples/api/lib/material/floating_action_button_location/standard_fab_location.0.dart`
Contributes to #130459 It adds a test for - `examples/api/lib/material/dropdown_menu/dropdown_menu.1.dart`
Work towards flutter/devtools#7894 The Flutter DevTools team is working on a new Widget Inspector. As part of this work, we need to make adjusts to the widget inspector service API. This PR simply re-factors the `widget_inspector_test` in preparation for this work, to make it easier for us to modify the tests / add new tests. Although this PR is large (`widget_inspector_test` is over 5000 lines!!), it does not change any of the current test logic. Instead it: - Moves test cases that were prefixed with "WidgetInspectorService" into the pre-existing group named "WidgetInspectorService" - Moves tests cases in that group which were skipped with `!WidgetInspectorService.instance.isWidgetCreationTracked() // [intended] Test requires --track-widget-creation flag` into a group called "Requires flag --track-widget-creation" - Adds two helper functions, `pumpWidgetTreeWithABC` and `findElementABC` and uses them in all test cases that were duplicating the same widget set-up.
…149875) flutter/engine@087feab...98e9393 2024-06-07 [email protected] Roll Skia from a7ee8897c66e to 376b88815099 (1 revision) (flutter/engine#53268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…149899) flutter/engine@98e9393...1cdbebe 2024-06-07 [email protected] Roll Dart SDK from accb5c25c42a to 7b239d7f4578 (1 revision) (flutter/engine#53272) 2024-06-07 [email protected] Roll Skia from d2e17d341305 to e36110f8b451 (1 revision) (flutter/engine#53271) 2024-06-07 [email protected] Roll Skia from 376b88815099 to d2e17d341305 (2 revisions) (flutter/engine#53270) 2024-06-07 [email protected] Roll Dart SDK from 41acb19a67b5 to accb5c25c42a (1 revision) (flutter/engine#53269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@586faa6...8a2c4e4 2024-06-06 [email protected] Revert "Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6882) 2024-06-06 [email protected] [two_dimensional_scrollables] Adds generics to the callbacks and builders of TreeView (flutter/packages#6864) 2024-06-06 [email protected] Run tests on macOS 13 or 14 (flutter/packages#6877) 2024-06-06 [email protected] Disable sandboxing directly for macOS tests (flutter/packages#6880) 2024-06-06 [email protected] [pigeon] Moves all codec logic to singular custom codec (flutter/packages#6600) 2024-06-06 [email protected] Roll Flutter (stable) from a14f74f to 761747b (6 revisions) (flutter/packages#6878) 2024-06-06 [email protected] Roll Flutter from 27e0656 to 4608a89 (17 revisions) (flutter/packages#6876) 2024-06-06 [email protected] Disable sandboxing for macOS tests in CI (flutter/packages#6866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes [`SegmentedButton` doesn't clip properly when one of the segments has `ColorFiltered`](#144990) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Center( child: SegmentedButton<int>( segments: const <ButtonSegment<int>>[ ButtonSegment<int>( value: 0, label: ColorFiltered( colorFilter: ColorFilter.mode(Colors.amber, BlendMode.colorBurn), child: Text('Option 1'), ), ), ButtonSegment<int>( value: 1, label: Text('Option 2'), ), ], onSelectionChanged: (Set<int> selected) {}, selected: const <int>{0}, ), ), ), ); } } ``` </details> ### Before  ### After 
…" (#149927) Reverts: #149739 Initiated by: QuncCccccc Reason for reverting: the newly-added unit test might cause the red tree Original PR Author: TahaTesser Reviewed By: {QuncCccccc} This change reverts the following previous change: fixes [`SegmentedButton` doesn't clip properly when one of the segments has `ColorFiltered`](#144990) ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Center( child: SegmentedButton<int>( segments: const <ButtonSegment<int>>[ ButtonSegment<int>( value: 0, label: ColorFiltered( colorFilter: ColorFilter.mode(Colors.amber, BlendMode.colorBurn), child: Text('Option 1'), ), ), ButtonSegment<int>( value: 1, label: Text('Option 2'), ), ], onSelectionChanged: (Set<int> selected) {}, selected: const <int>{0}, ), ), ), ); } } ``` </details> ### Before  ### After 
A sliver that remains �pinned� to the top of the scroll view. Subsequent slivers scroll behind it. Typically the sliver is created as the first item in the list however it can be inserted anywhere and it will always stop at the top of the scroll view. When the scrolling axis is vertical, the PinnedHeaderSliver�s height is defined by its widget child. Multiple PinnedHeaderSlivers will layout one after the other, once they've scrolled to the top. This sliver is preferable to the general purpose SliverPersistentHeader - for its relatively narrow use case - because there's no need to create a [SliverPersistentHeaderDelegate] or to predict the header's size. Here's a [working demo in DartPad](https://dartpad.dev/?id=3b3f24c14fa201f752407a21ca9c9456). https://github.com/flutter/flutter/assets/1377460/943f2e02-8e73-48b7-90be-61168978ff71 Related sliver utility PRs: #143538, #143325, #127340.
Instead I've added @andrewkolos for tools tests and @jtmcdole for engine tests. This doesn't mean you have to investigate and solve the issues filed by the flake bot. Instead, an assignee is just the mechanism used by the flake bot to ensure that the issues are triaged at the appropriate team triage meetings. FYI @christopherfujino
…149944) flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…visions) (#149944)" (#149960) Reverts: #149944 Initiated by: jason-simmons Reason for reverting: Regression affecting `integration_test/test/web_extension_test.dart` ``` PathNotFoundException: Cannot open file, path = '/chromium/canvaskit.wasm' (OS Error: No such file or directory, errno = 2) ``` (see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745735238400976001/+/u/run_test.dart_for_web_long_running_tests_shard_and_subshard_1_5/stdout) It looks like the p Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@1cdbebe...45cf05f 2024-06-07 [email protected] [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 [email protected] Update Chrome to 125. (flutter/engine#53282) 2024-06-07 [email protected] Roll Dart SDK from 4b693b16eec1 to d4f17e0bf28b (1 revision) (flutter/engine#53283) 2024-06-07 [email protected] Fixes a few issues in flutter_js (flutter/engine#53231) 2024-06-07 [email protected] Roll Fuchsia Linux SDK from aVohW_hnfDaE0smBX... to zpBZmUB_JC5AjG-f4... (flutter/engine#53279) 2024-06-07 [email protected] Roll Dart SDK from 7b239d7f4578 to 4b693b16eec1 (1 revision) (flutter/engine#53277) 2024-06-07 [email protected] Roll Skia from b7f51dfcc342 to ad3c9f203f4e (1 revision) (flutter/engine#53276) 2024-06-07 [email protected] Roll Skia from 5fc83884a619 to b7f51dfcc342 (4 revisions) (flutter/engine#53275) 2024-06-07 [email protected] Revert "Widen CPU affinity set." (flutter/engine#53274) 2024-06-07 [email protected] Roll Skia from e36110f8b451 to 5fc83884a619 (1 revision) (flutter/engine#53273) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aVohW_hnfDaE to zpBZmUB_JC5A If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR matches the various colors of `CupertinoActionSheet` more closely with the native one. The following colors are changed. * Sheet background color * Pressed button color * Cancel button color * Pressed cancel button color * Divider color * Content text color The resulting colors match with native one with deviation of at most 1 (in terms of 0~255 RGB). The following are comparison (left to right: Native, Flutter after PR, Flutter current) <img width="1295" alt="image" src="https://github.com/flutter/flutter/assets/1596656/3703a4a8-a856-42b1-9395-a6e14b1881ca"> <img width="1268" alt="image" src="https://github.com/flutter/flutter/assets/1596656/1eb9964e-41f1-414a-99ae-0a2e7da8d3fd"> _Note: The divider thickness is adjusted to `1/dpr` instead of 0.3 in both Flutter version to make them look more native, as will be proposed in #149636 ### Derivation All the colors are derived through color picker and calculation. The algorithm is as followed: * Assume all colors are translucent grey colors, i.e. having the same value `x` for R, G, and B, with an alpha `a`. * Given the barrier color is `x_B1=0` when the background is black, and `x_B2=204` when the background is white. * Pick the target color `x_t1` when the background is black, and `x_t2` when the background is white * Solve the following equations for `x` and `a` ``` a * x + (1-a) * x_B1 = x_t1 a * x + (1-a) * x_B2 = x_t2 a = 1 - (x_t1 - x_t2) / (x_B1 - x_B2) x = (x_t1 - (1-a) * x_B1) / a ``` These equations use a linear model for color composition, which might not be exact, but is close enough for an accuracy of (1/255). The full table is as follows: <img width="1091" alt="image" src="https://github.com/flutter/flutter/assets/1596656/0fb76291-c3cc-4bb5-aefa-03ac6ac9bf1f"> * The first two columns are colors picked from XCode. * The 3~4 columns are the colors picked from the current Flutter. Notice the deviation, which is sometimes drastic. * The 5~6 columns are the colors picked from Flutter after this PR. The deviation is at most 1. * The last few columns are calculation. * There are two rows whose calculation is based on adjusted numbers, since the original results are not accurate enough, possibly due to the linear composition. During the calculation, I assumed these colors vary between light and dark modes, but it turns out that both modes use the same set of colors. ### Screenshots
…9998) This reverts commit 32081aa. Reason for revert: Appears to be failing tests in tree ``` 01:48 +2991 ~18: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart: Taps on a button can be slided to other buttons â��â��â�¡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â��â�� The following SkiaException was thrown while running async test code: Skia Gold received an unapproved image in post-submit testing. Golden file images in flutter/flutter are triaged in pre-submit during code review for the given PR. Visit https://flutter-gold.skia.org/ to view and approve the image(s), or revert the associated change. For more information, visit the wiki: https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter Debug information for Gold -------------------------------- stdout: Given image with hash 601f421e3bb643f437cc12395de96152 for test cupertino.cupertinoActionSheet.press-drag Expectation for test: ce8ef79c146857d162663b1161fd6d5c (positive) Expectation for test: 3bb57a8782f67836c6ad3ece7f00729a (positive) Expectation for test: 3f8c592774caf3c760fbbd318a7dc5af (positive) Expectation for test: 61863f38217aa3349c239eeb49b84930 (positive) Expectation for test: 98af16e9b7eb3fb810b44c74bb18ffb9 (positive) Untriaged or negative image: https://flutter-gold.skia.org//detail?grouping=name%3Dcupertino.cupertinoActionSheet.press-drag%26source_type%3Dflutter&digest=601f421e3bb643f437cc12395de96152 stderr: Test: cupertino.cupertinoActionSheet.press-drag FAIL result-state.json: No result file found. ```
Package is being transferred to the `dart-lang` github org: #141808
…9773) - When `--web-renderer` is omitted, keep the value `null` until it later materializes to either `canvaskit` or `skwasm`. - No more hardcoded defaults anywhere. We use `WebRendererMode.defaultForJs/defaultForWasm` instead. - When in `--wasm` mode, the JS fallback is now `canvaskit` instead of `auto`. - Add test for defaulting to `skwasm` when `--wasm` is enabled. Fixes #149826
This PR addresses an issue with TextPainter's caret position calculation for text containing full-width spaces. Currently, the caret position is not accurately calculated for strings with full-width spaces. To resolve this, the following changes have been made: Corrected the logic for caret position calculation when full-width spaces are present in the text. Added and updated test cases to ensure accurate caret position calculation. These changes ensure that the caret position for text with full-width spaces is computed correctly. This issue was introduced by the commit [a0a854a](a0a854a). Related Issue: [#149099](#149099)
Notifies the engine when `PointerSignalEvents` have been ignored by the framework, through the `ui.PointerData.respond` method. This allows the web to "preventDefault" (or not) on `wheel` events. ## Issues * Fixes (partially): #139263 ## Tests * Added tests to ensure `respond` is called at the right time, with the right value. ## Demo * https://dit-multiview-scroll.web.app <details> <summary> ## Previous versions </summary> 1. Modified `PointerScrollEvent`, not shippable. 2. Modified when events were handled, instead of the opposite. </details>
flutter/packages@8a2c4e4...e95fe4a 2024-06-07 [email protected] Manual roll Flutter from 4608a89 to fc19ecf (38 revisions) (flutter/packages#6890) 2024-06-07 [email protected] [pigeon] Fix handling of null class args in C++ (flutter/packages#6881) 2024-06-07 [email protected] [video_player_android] Migrate ExoPlayer to ExoPlayer-Media3 1.3.1 (flutter/packages#6535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…wasm (#149996) Dart2Wasm doesn't officially support `dart:ffi` (only a small sketchy subset needed in flutter web engine). We have seen user reporting issues where existing packages don't work with dart2wasm due to using `dart.library.ffi` in `bool.fromEnvironment` or in conditional imports and it doing the wrong thing. So we're going to make `dart.library.ffi` `false` in the compiler. We therefore update the code to detect whether it runs under wasm via a new `dart.tool.dart2wasm` environment variable. This is a preparation for the change in dart2wasm which will start making `const bool.fromEnvironment('dart.library.ffi')` return `false` instead of `true`.
Temporary solution for #150008.
flutter/packages@03f5f6d...412ec46 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.10 (flutter/packages#6924) 2024-06-27 [email protected] [video_player] Exposes VideoPlayerWebOptions. (flutter/packages#6990) 2024-06-27 [email protected] [ci] Add Wasm compilation to all_packages web app. (flutter/packages#6981) 2024-06-27 [email protected] [interactive_media_ads] Updates `README` with a usage section and fix some interface docs (flutter/packages#6988) 2024-06-27 [email protected] [tools] Fix vm test requirement (flutter/packages#6995) 2024-06-27 [email protected] Update `web_benchmarks` package to properly support wasm. (flutter/packages#6970) 2024-06-27 [email protected] [pigeon] Implement equals for Java data classes (flutter/packages#6992) 2024-06-25 [email protected] Final refactor of `video_player_android` before `SurfaceProducer#setCallback`. (flutter/packages#6982) 2024-06-25 [email protected] [pigeon] Update testing and docs (flutter/packages#6984) 2024-06-25 [email protected] [various] Update flutter.dev links to more reliable destinations (flutter/packages#6963) 2024-06-25 [email protected] [interactive_media_ads] Adds initial Android implementation (flutter/packages#6733) 2024-06-25 [email protected] Roll Flutter from 6c06abb to e726eb4 (51 revisions) (flutter/packages#6987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The Pull Request changes the `dartSdkVersionBounds` value, which gets templated into the `pubspec.yaml` from the `flutter create`: https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8 As from the Dart dependencies ["Best practices"](https://dart.dev/tools/pub/dependencies#use-caret-syntax) section of the documentation: > Use caret syntax Specify dependencies using the [caret syntax](https://dart.dev/tools/pub/dependencies#caret-syntax). This allows the pub tool to select newer versions of the package when they become available. Further, it places an upper bound on the allowed version. To learn more about the Caret syntax, refer to the [Caret syntax documentation](https://github.com/flutter/flutter/blob/ffdeaa1995efc1fe7d759e13b92eba1ec57beea6/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L8). **Additional context** - VGVentures/io_crossword#592 (comment) (cc: @kevmoo) - [Very Good Templates](https://github.com/VeryGoodOpenSource/very_good_templates) relies on the Caret syntax when templating the Dart SDK
The Gradle Kotlin DSL also allows for type-safe application of the Flutter Gradle plugin, which is currently undetected by the CLI
```kotlin
plugins {
dev.flutter.`flutter-gradle-plugin`
}
```
Please note that the added test case isn't ideal, since the example gradle isn't actually valid kotlin DSL, however the `kotlin host app language with Gradle Kotlin DSL` is identical
Fixes #149859
Reopened after revert in #147658 Another test was added in the meantime to `draggable_test.dart` that didn't call `gesture.up()`. I added this call to the test and now all tests pass. --- # Original Description (#145647): We changed the coordinates used to position the `Draggable` feedback by transforming them into the `Overlay`s coordinate space. This has no influence on any untransformed `Overlay`, most Flutter apps should be not affected. This PR fixes the positioning of the feedback in transformed context (see #145639 for before video): https://github.com/flutter/flutter/assets/42270125/df34e198-0667-453d-a27a-a79b2e2825a1 - fixes #145639 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes --------- Co-authored-by: Jesper Bellenbaum <[email protected]>
…151002) flutter/engine@a78f5ce...2f7e9ab 2024-06-28 [email protected] Roll Skia from 7a09d38fa7f8 to 3d5f5d546fb6 (1 revision) (flutter/engine#53634) 2024-06-28 [email protected] Roll Skia from 23a14cccc800 to 7a09d38fa7f8 (1 revision) (flutter/engine#53633) 2024-06-28 [email protected] Roll Skia from cd77153f20a8 to 23a14cccc800 (1 revision) (flutter/engine#53631) 2024-06-28 [email protected] Revert "[DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53629) 2024-06-28 [email protected] Roll Dart SDK from 4005e5f1fb8e to 341dbaf977a3 (1 revision) (flutter/engine#53630) 2024-06-28 [email protected] Roll Skia from 6650fcc6d054 to cd77153f20a8 (1 revision) (flutter/engine#53628) 2024-06-28 [email protected] Roll Skia from 2204428a75ca to 6650fcc6d054 (2 revisions) (flutter/engine#53627) 2024-06-28 [email protected] Roll Dart SDK from 0820b0766ac9 to 4005e5f1fb8e (1 revision) (flutter/engine#53626) 2024-06-28 [email protected] Roll Skia from 1700e3962acd to 2204428a75ca (1 revision) (flutter/engine#53625) 2024-06-28 [email protected] Roll Fuchsia Linux SDK from gBWzGuicxu76K82lg... to H_P7EHb4zXXV-Eiik... (flutter/engine#53624) 2024-06-28 [email protected] [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53622) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from gBWzGuicxu76 to H_P7EHb4zXXV If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.10 to 3.25.11. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p> <blockquote> <h1>CodeQL Action Changelog</h1> <p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p> <p>Note that the only difference between <code>v2</code> and <code>v3</code> of the CodeQL Action is the node version they support, with <code>v3</code> running on node 20 while we continue to release <code>v2</code> to support running on node 16. For example <code>3.22.11</code> was the first <code>v3</code> release and is functionally identical to <code>2.22.11</code>. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.</p> <h2>[UNRELEASED]</h2> <p>No user facing changes.</p> <h2>3.25.11 - 28 Jun 2024</h2> <ul> <li>Avoid failing the workflow run if there is an error while uploading debug artifacts. <a href="https://redirect.github.com/github/codeql-action/pull/2349">#2349</a></li> <li>Update default CodeQL bundle version to 2.17.6. <a href="https://redirect.github.com/github/codeql-action/pull/2352">#2352</a></li> </ul> <h2>3.25.10 - 13 Jun 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.5. <a href="https://redirect.github.com/github/codeql-action/pull/2327">#2327</a></li> </ul> <h2>3.25.9 - 12 Jun 2024</h2> <ul> <li>Avoid failing database creation if the database folder already exists and contains some unexpected files. Requires CodeQL 2.18.0 or higher. <a href="https://redirect.github.com/github/codeql-action/pull/2330">#2330</a></li> <li>The init Action will attempt to clean up the database cluster directory before creating a new database and at the end of the job. This will help to avoid issues where the database cluster directory is left in an inconsistent state. <a href="https://redirect.github.com/github/codeql-action/pull/2332">#2332</a></li> </ul> <h2>3.25.8 - 04 Jun 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.4. <a href="https://redirect.github.com/github/codeql-action/pull/2321">#2321</a></li> </ul> <h2>3.25.7 - 31 May 2024</h2> <ul> <li>We are rolling out a feature in May/June 2024 that will reduce the Actions cache usage of the Action by keeping only the newest TRAP cache for each language. <a href="https://redirect.github.com/github/codeql-action/pull/2306">#2306</a></li> </ul> <h2>3.25.6 - 20 May 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.3. <a href="https://redirect.github.com/github/codeql-action/pull/2295">#2295</a></li> </ul> <h2>3.25.5 - 13 May 2024</h2> <ul> <li>Add a compatibility matrix of supported CodeQL Action, CodeQL CLI, and GitHub Enterprise Server versions to the <a href="https://github.com/github/codeql-action/blob/main/README.md">https://github.com/github/codeql-action/blob/main/README.md</a>. <a href="https://redirect.github.com/github/codeql-action/pull/2273">#2273</a></li> <li>Avoid printing out a warning for a missing <code>on.push</code> trigger when the CodeQL Action is triggered via a <code>workflow_call</code> event. <a href="https://redirect.github.com/github/codeql-action/pull/2274">#2274</a></li> <li>The <code>tools: latest</code> input to the <code>init</code> Action has been renamed to <code>tools: linked</code>. This option specifies that the Action should use the tools shipped at the same time as the Action. The old name will continue to work for backwards compatibility, but we recommend that new workflows use the new name. <a href="https://redirect.github.com/github/codeql-action/pull/2281">#2281</a></li> </ul> <h2>3.25.4 - 08 May 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.2. <a href="https://redirect.github.com/github/codeql-action/pull/2270">#2270</a></li> </ul> <h2>3.25.3 - 25 Apr 2024</h2> <ul> <li>Update default CodeQL bundle version to 2.17.1. <a href="https://redirect.github.com/github/codeql-action/pull/2247">#2247</a></li> <li>Workflows running on <code>macos-latest</code> using CodeQL CLI versions before v2.15.1 will need to either upgrade their CLI version to v2.15.1 or newer, or change the platform to an Intel MacOS runner, such as <code>macos-12</code>. ARM machines with SIP disabled, including the newest <code>macos-latest</code> image, are unsupported for CLI versions before 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/2261">#2261</a></li> </ul> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/github/codeql-action/commit/b611370bb5703a7efb587f9d136a52ea24c5c38c"><code>b611370</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2357">#2357</a> from github/update-v3.25.11-de945755c</li> <li><a href="https://github.com/github/codeql-action/commit/3e6431f3accd84bb42779fc3c9d9f447caa3a6d3"><code>3e6431f</code></a> Update changelog for v3.25.11</li> <li><a href="https://github.com/github/codeql-action/commit/de945755c9edd3a4e5d160a71f1482ece6a3c271"><code>de94575</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2352">#2352</a> from github/update-bundle/codeql-bundle-v2.17.6</li> <li><a href="https://github.com/github/codeql-action/commit/a32d3058b827f5d2ba08dc2570887f14b164a794"><code>a32d305</code></a> Add changelog note</li> <li><a href="https://github.com/github/codeql-action/commit/9ccc99508a819cb9c340028d7711b129f96c8a2e"><code>9ccc995</code></a> Update default bundle to codeql-bundle-v2.17.6</li> <li><a href="https://github.com/github/codeql-action/commit/9b7c22c3b39078582fa6d0d8f3841e944ec54582"><code>9b7c22c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2351">#2351</a> from github/dependabot/npm_and_yarn/npm-6791eaa26c</li> <li><a href="https://github.com/github/codeql-action/commit/9cf3243b0be3a9e0efff20a7fabd5a11246168e9"><code>9cf3243</code></a> Rebuild</li> <li><a href="https://github.com/github/codeql-action/commit/1895b29ac8e2046ddb708ac1eca53e6d5e143337"><code>1895b29</code></a> Update checked-in dependencies</li> <li><a href="https://github.com/github/codeql-action/commit/9dcfde966d641c9a59ee02a83f18329a2b2caace"><code>9dcfde9</code></a> Bump the npm group with 2 updates</li> <li><a href="https://github.com/github/codeql-action/commit/8723b5be41df185b62efd22191bb83fc24539ca0"><code>8723b5b</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2350">#2350</a> from github/angelapwen/add-exclude-pr-check-param</li> <li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/23acc5c183826b7a8a97bce3cecc52db901f8251...b611370bb5703a7efb587f9d136a52ea24c5c38c">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…151013) flutter/engine@2f7e9ab...f828363 2024-06-28 [email protected] Roll Skia from fc6f00bfacb5 to 1ad84eb8e94f (2 revisions) (flutter/engine#53641) 2024-06-28 [email protected] Roll Skia from 3d5f5d546fb6 to fc6f00bfacb5 (1 revision) (flutter/engine#53637) 2024-06-28 [email protected] Roll Dart SDK from 341dbaf977a3 to 89b164e3adeb (2 revisions) (flutter/engine#53636) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR was generated by `flutter update-packages --force-upgrade`.
This PR was generated by `flutter update-packages --force-upgrade`.
Contributes to #130459 It adds a test for - `examples/api/test/material/segmented_button/segmented_button.0_test.dart`
…151016) flutter/engine@f828363...ad1343c 2024-06-28 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 [email protected] Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 [email protected] [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…rees (#151049) With today's random test order (--test-randomize-ordering-seed=20240629) this test is failing due to stack overflows when run on Windows.
…151062) flutter/engine@ad1343c...0d93da7 2024-06-30 [email protected] Roll Fuchsia Linux SDK from zU9wwHk8Oji6pArmw... to DSPuQ9O6WejkIBUUh... (flutter/engine#53657) 2024-06-29 [email protected] Roll Dart SDK from e1e2b16d509b to ab6a48438e07 (1 revision) (flutter/engine#53655) 2024-06-29 [email protected] Roll Skia from 2df28ce437cc to 34be7c830184 (1 revision) (flutter/engine#53654) 2024-06-29 [email protected] Roll Skia from bc0e9542ce83 to 2df28ce437cc (1 revision) (flutter/engine#53652) 2024-06-29 [email protected] Roll Fuchsia Linux SDK from H_P7EHb4zXXV-Eiik... to zU9wwHk8Oji6pArmw... (flutter/engine#53649) 2024-06-29 [email protected] [web] Fixes drag scrolling in embedded mode. (flutter/engine#53647) 2024-06-29 [email protected] Roll Dart SDK from 160ace00da8a to e1e2b16d509b (1 revision) (flutter/engine#53646) 2024-06-28 [email protected] Roll Skia from 1ad84eb8e94f to bc0e9542ce83 (1 revision) (flutter/engine#53644) 2024-06-28 [email protected] Roll Dart SDK from 89b164e3adeb to 160ace00da8a (1 revision) (flutter/engine#53643) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from H_P7EHb4zXXV to DSPuQ9O6Wejk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…151082) flutter/engine@0d93da7...b57a044 2024-07-01 [email protected] Roll Dart SDK from ab6a48438e07 to 338c6d4fd9c5 (1 revision) (flutter/engine#53658) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This test suite had been failing when run with --test-randomize-ordering-seed=20240701
This PR was generated by `flutter update-packages --force-upgrade`.
docimports for references in doc comments on library statements now work! Part of #150800
…151127) flutter/engine@b57a044...3456fee 2024-07-01 [email protected] Roll Skia from a67a67b7452b to a62bf018429c (2 revisions) (flutter/engine#53665) 2024-07-01 [email protected] Roll Skia from 8af866a56bce to a67a67b7452b (1 revision) (flutter/engine#53664) 2024-07-01 [email protected] Roll Fuchsia Linux SDK from DSPuQ9O6WejkIBUUh... to LkXpxHsQlkPT4mmJ7... (flutter/engine#53663) 2024-07-01 [email protected] Roll Skia from e27104eaef37 to 8af866a56bce (4 revisions) (flutter/engine#53661) 2024-07-01 [email protected] Roll Skia from 34be7c830184 to e27104eaef37 (1 revision) (flutter/engine#53659) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from DSPuQ9O6Wejk to LkXpxHsQlkPT If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…d tests (#150969) After the land of flutter/engine#53592, there is some log spam: ``` e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. ... ``` I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after #146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways. In a follow up PR: 1. Also upgrade the tests that were left behind in #146307, as I think removal of discontinued plugins paved the way here.
…sions, and tests (#150969)" (#151147) Reverts: #150969 Initiated by: goderbauer Reason for reverting: Failing test in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8743574743030691569/+/u/run_android_obfuscate_test/stdout Original PR Author: gmackall Reviewed By: {christopherfujino, reidbaker} This change reverts the following previous change: After the land of flutter/engine#53592, there is some log spam: ``` e: /Users/mackall/.gradle/caches/transforms-3/c1e137371ec1afe9bc9bd7b05823752d/transformed/fragment-1.7.1/jars/classes.jar!/META-INF/fragment_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. e: /Users/mackall/.gradle/caches/transforms-3/d86c7cb1c556fe1655fa56db671c649c/transformed/jetified-activity-1.8.1/jars/classes.jar!/META-INF/activity_release.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0. ... ``` I think this is harmless, but still annoying. Upgrading the AGP version fixes it. To be honest, I don't know why (I expected the Kotlin version would do it). But after #146307, our tests have been running on AGP/Gradle 8.1/8.3 for a while, so it makes sense to upgrade anyways. In a follow up PR: 1. Also upgrade the tests that were left behind in #146307, as I think removal of discontinued plugins paved the way here.
I really like how patterns can be used for variable assignment and avoiding duplicated logic. (related: #150942) ```dart // before final GestureRecognizer? recognizer = info.recognizer; if (recognizer is TapGestureRecognizer) { if (recognizer.onTap != null) { configuration.onTap = recognizer.onTap; configuration.isLink = true; } } else if (recognizer is DoubleTapGestureRecognizer) { if (recognizer.onDoubleTap != null) { configuration.onTap = recognizer.onDoubleTap; configuration.isLink = true; } } // after switch (info.recognizer) { case TapGestureRecognizer(:final VoidCallback? onTap): case DoubleTapGestureRecognizer(onDoubleTap: final VoidCallback? onTap): if (onTap != null) { configuration.onTap = onTap; configuration.isLink = true; } } ```
Cleans up printTrace calls added while investigating #146879. Also makes[ this `catch` clause ](https://github.com/flutter/flutter/pull/151074/files#diff-214723283174eb75e740a102252215723aa56716226ea92d084ef8a5bea4e931L578-R581)more precise.
…151150) flutter/engine@3456fee...fc5bc14 2024-07-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Output .js files as ES6 modules. (#52023)" (flutter/engine#53674) 2024-07-01 [email protected] Roll Dart SDK from 21c08743ee4a to c23e58143793 (1 revision) (flutter/engine#53670) 2024-07-01 [email protected] Roll Skia from ae2b97d74812 to 8375bdc6e191 (3 revisions) (flutter/engine#53669) 2024-07-01 [email protected] Output .js files as ES6 modules. (flutter/engine#52023) 2024-07-01 [email protected] Roll Skia from a62bf018429c to ae2b97d74812 (3 revisions) (flutter/engine#53668) 2024-07-01 [email protected] [icu] Ignores the dir `flutter/third_party/icu/patches` (flutter/engine#53667) 2024-07-01 [email protected] [Impeller] track the sizes of all outstanding MTLTexture allocations and report per frame in MB, matching Vulkan implementation. (flutter/engine#53618) 2024-07-01 [email protected] Roll Dart SDK from 338c6d4fd9c5 to 21c08743ee4a (1 revision) (flutter/engine#53666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ction is short (#150708) This PR addresses a bug from the previous rewrite of the `CupertinoActionSheet` height allocation algorithm. The previous approach assigns the content section with a minimal height. As a result, if the actions section is shorter than `_kActionSheetActionsSectionMinHeight`, the remaining space will not be taken by the content section. As far as I know, this algorithm can not be implemented by simply compositing simple layout widgets, and therefore I created a new widget `_PriorityColumn` that uses a custom layout algorithm. (The resulting code is still shorter (and cleaner) than before the rewrite!) Some other trivial refactor is also done to clean up the code around parameters of `_ActionSheetMainSheet`.
…151155) flutter/engine@fc5bc14...d3c5bd6 2024-07-02 [email protected] Manual roll ICU from 98f2494518c2 to 43953f57b037 (1 revision) (flutter/engine#53675) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.