-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust aws_c5.18xlarge memory size #991
Conversation
Please let me know if this needs to be updated, @kiukchung. Thanks! |
Could you please check this small PR, @kiukchung @d4l3k? |
I seem to have lost approve/merge/run-workflow access to this repo... cc) @d4l3k @yikaiMeta |
Could you please have a look, @tonykao8080? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Thanks @tonykao8080 let me amend+force-push to kick-start that linter check |
My bad, @tonykao8080 used This time the change is right and hopefully the linter will start too. |
de37faf
to
0fe4c85
Compare
This should pass the linter now, @tonykao8080 |
@kiukchung @tonykao8080 With the change being approved and the failure in Docs Builder being unrelated. Is there anything else left to do before we can merge this PR? Thanks! |
MEM_TAX
is not enough to adjust memory size for the actual memory we get:Test plan:
142 * GiB