Add Hud x-token in lambda #7511
Merged
+37
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
meta-cla
bot
added
the
CLA Signed
huydhn
reviewed
Nov 22, 2025
| type=str, | ||
| help="the end time to run, in format of YYYY-MM-DD HH:MM:SS", | ||
| ) | ||
| parser.add_argument( |
Contributor
There was a problem hiding this comment.
Nit: This looks redundant because it will default to ENVS["HUD_INTERNAL_BOT_TOKEN"] anyway. Why not just check for that envvars, and use it if it's set
huydhn
reviewed
Nov 22, 2025
| @classmethod | ||
| def from_request( | ||
| cls, url: str, query: dict, timeout: int = 180 | ||
| cls, url: str, query: dict, access_token:str, timeout: int = 180 |
Contributor
There was a problem hiding this comment.
Nit: There are a couple for formatting changes in this PR that are rather unexpected like access_token:str here. A good BE task would be to enable linter for python lambda. I'm thinking ruff check and ruff format
clee2000
added a commit
that referenced
this pull request
Nov 24, 2025
I added the token to the secrets for test-infra Like #7511
huydhn
pushed a commit
that referenced
this pull request
Nov 25, 2025
Also changed the URL since that's the main reason I missed this one (I was searching for hud.pytorch.org/api) Similar to #7511 Testing: added pr trigger to test https://github.com/pytorch/test-infra/actions/runs/19646178221/job/56261830650?pr=7513 An example failure is https://github.com/pytorch/test-infra/actions/runs/19645854442/job/56260785042 (if the link expires, the result was that the api gets 429 and all the jobs fail)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add token in pytorch-lab/pytorch now, modify code to access it