Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flickering white on page load / reload #6431

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

wdvr
Copy link
Contributor

@wdvr wdvr commented Mar 17, 2025

This is fixed by adding a _document file, that renders server side and prerenders based on dark / light mode to avoid setting colors after initial render.

https://nextjs.org/docs/pages/building-your-application/routing/custom-document

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 17, 2025 8:53pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit too complx

@@ -7,6 +7,7 @@
width: 100%;
min-height: 60px;
align-items: center;
transition: background 0.3s ease, box-shadow 0.3s ease;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My .css foo is pretty stale, what browser will support those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://caniuse.com/css-transitions -> all of them except for ie9 and opera mini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants