Fix some bugs in upload benchmark scripts #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
huydhn
commented
Mar 17, 2025
| @@ -172,7 +172,8 @@ def upload_to_dynamodb( | |||
| """ | |||
| Copied from upload stats script | |||
| """ | |||
| info(f"Writing {len(docs)} documents to DynamoDB {dynamodb_table}") | |||
| msg = f"Writing {len(docs)} documents to DynamoDB {dynamodb_table}" | |||
There was a problem hiding this comment.
This comes from https://google.github.io/styleguide/pyguide.html#3101-logging, I'm lazy and just move the message to a variable to silent the warning.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
yangw-dev
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #6425, I discover several bugs in the upload scripts:
Testing
https://github.com/pytorch/test-infra/actions/runs/13909203687/job/38919334944#step:5:125 looks correct now