Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table background overflow #6423

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix table background overflow #6423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42bb1f
fix table background overflow
wdvr Mar 17, 2025
4496c6b
fix lint
wdvr Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion torchci/components/hud.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
border-collapse: collapse;
width: max-content;
line-height: 1;
padding: 0;
}

/* Table wrapper with background to support rotated headers */
.hudTableContainer {
background-color: var(--dropdown-bg);
display: inline-block;
padding-right: 100px;
margin-right: -100px; /* Offset the padding to maintain original spacing */
}

/* Fix the width of these columns to avoid layout shift when loading the HUD
Expand All @@ -22,6 +31,7 @@
.colJob {
width: 1.2ch;
min-width: 14px;
position: relative; /* Add this to extend background */
}
.colAuthor {
width: 12ch;
Expand Down Expand Up @@ -51,7 +61,7 @@
flex: 1;
}

/* code to roatate the workflow name headers */
/* code to rotate the workflow name headers */
.jobHeader {
font-family: sans-serif;
height: 150px;
Expand Down
15 changes: 10 additions & 5 deletions torchci/pages/hud/[repoOwner]/[repoName]/[branch]/[[...page]].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,11 +329,16 @@ function GroupFilterableHudTable({
/>
<MonsterFailuresCheckbox />
</div>
<table className={styles.hudTable} style={{ overflow: "auto" }}>
<GroupHudTableColumns names={headerNames} />
<GroupHudTableHeader names={headerNames} />
{children}
</table>
{/* Table wrapper with custom class for extended background */}
<div style={{ overflowX: "auto" }}>
<div className={styles.hudTableContainer}>
<table className={styles.hudTable}>
<GroupHudTableColumns names={headerNames} />
<GroupHudTableHeader names={headerNames} />
{children}
</table>
</div>
</div>
</div>
</>
);
Expand Down