Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUD] Adds dashboard in Metrics page to track ephemeral experimentation % over time #6420

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

jeanschmidt
Copy link
Contributor

Adds a dashboard with title "Percentage of jobs on ephemeral experiment" on metrics page of hud.

Query is a copy-paste-change-a-bit from meta/lf runners. This dashboard is temporary and we should be removing it as we finish the experiment and the migration.

Once we do that, the above mentioned dashboard and the nonephemeral metric in SLI page should be removed.

Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Mar 18, 2025 2:42pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2025
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine since it's a temporary one, but I'm thinking we may be better served by either turning the original lf_rollover_percentage query into one that accepts an experiment as an input (easier option) or converting the chart into one that shows the status of all experiments that are currently in progress (more work, but gives us free metrics for all future experiments)

@jeanschmidt
Copy link
Contributor Author

I really liked your idea, I'll evaluate the best path forward and then implement and polish the code to make it more permanent-friendly

@jeanschmidt jeanschmidt merged commit e01c392 into main Mar 18, 2025
6 checks passed
@jeanschmidt jeanschmidt deleted the jeanschmidt/metrics_ephemeral_experiment branch March 18, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants