[queue time] Add Job Queue Time hook #6417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
yangw-dev
commented
Mar 15, 2025
| id: aws_creds | ||
| uses: aws-actions/configure-aws-credentials@v3 | ||
| with: | ||
| role-to-assume: arn:aws:iam::308535385114:role/gha_workflow_update_queue_times |
There was a problem hiding this comment.
FYI I used the same aws role as the update-queue-times.yml.
@jeanschmidt
There was a problem hiding this comment.
Don't do that, each role for each UC.
|
I don't like that we're using test-infra ci for those kind of jobs. I believe we should stop this bad engineering standard. Maybe this should be a AWS lambda? |
jeanschmidt
reviewed
Mar 17, 2025
| @@ -0,0 +1,26 @@ | |||
| name: Update job queue times dataset | |||
There was a problem hiding this comment.
I don't think it is a good standard to use GHA CI for chron jobs, I believe we should be using lambdas or other things for this.
There was a problem hiding this comment.
just curious, is there reason why the old one exists?
jeanschmidt
requested changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add git work to insert new queue time data into s3 every 15 minutes,
the new data includes:
{ queue_s, repo, workflow_name , job_name, machine_type, time}
Pending PR for permission:
https://github.com/pytorch-labs/pytorch-gha-infra/pull/627
Pending PR for db schema:
#6418
Design Doc:
https://docs.google.com/document/d/1OiPv-ku_NvMgvnaMIbtnIEHTixJY28CBaKeMKJtglEk/edit?tab=t.0#heading=h.87bg49h503n7
Details
working result in s3
https://us-east-1.console.aws.amazon.com/s3/object/ossci-raw-job-status?region=us-east-1&bucketType=general&prefix=job_queue_times_historical/pytorch/pytorch/1742001203.txt