-
Notifications
You must be signed in to change notification settings - Fork 100
Enable windows arm64 builds for vision #6352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
561e93b
795975b
7293512
001d221
07893bb
c9a8eb5
127cdc0
ad2318c
1a45a6a
4bfb3d1
bb2132a
78cede4
3f78038
b5a68e7
0b53e18
0ced2d4
49386cc
a7d414a
96ec944
629c5b0
1dbeeb7
e384918
b04070d
1033651
7372b89
16b8f45
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#!/bin/bash | ||
|
||
echo "Dependency MSVC Build Tools with C++ with ARM64/ARM64EC components installation started." | ||
|
||
# Pre-check for downloads and dependencies folders | ||
mkdir -p "$DOWNLOADS_DIR" | ||
mkdir -p "$DEPENDENCIES_DIR" | ||
|
||
# Set download URL for the Visual Studio Installer | ||
DOWNLOAD_URL="https://aka.ms/vs/17/release/vs_BuildTools.exe" | ||
INSTALLER_FILE="$DOWNLOADS_DIR/vs_BuildTools.exe" | ||
|
||
# Download installer | ||
echo "Downloading Visual Studio Build Tools with C++ installer..." | ||
curl -L -o "$INSTALLER_FILE" "$DOWNLOAD_URL" | ||
|
||
# Install the Visual Studio Build Tools with C++ components | ||
echo "Installing Visual Studio Build Tools with C++ components..." | ||
echo "Installing MSVC $MSVC_VERSION" | ||
"$INSTALLER_FILE" --norestart --quiet --wait --installPath "$DEPENDENCIES_DIR/VSBuildTools" \ | ||
--add Microsoft.VisualStudio.Workload.VCTools \ | ||
--add Microsoft.VisualStudio.Component.Windows10SDK \ | ||
--add Microsoft.VisualStudio.Component.Windows11SDK.22621 \ | ||
--add Microsoft.VisualStudio.Component.VC.ASAN \ | ||
--add Microsoft.VisualStudio.Component.VC.CMake.Project \ | ||
--add Microsoft.VisualStudio.Component.VC.CoreBuildTools \ | ||
--add Microsoft.VisualStudio.Component.VC.CoreIde \ | ||
--add Microsoft.VisualStudio.Component.VC.Redist.14.Latest \ | ||
--add Microsoft.VisualStudio.Component.VC.Tools.ARM64EC \ | ||
--add Microsoft.VisualStudio.Component.VC.Tools.ARM64 \ | ||
--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 | ||
|
||
# Check if installation was successful | ||
if [[ $? -ne 0 ]]; then | ||
echo "Failed to install Visual Studio Build Tools with C++ components." | ||
exit 1 | ||
fi | ||
|
||
echo "Dependency Visual Studio Build Tools with C++ installation finished." |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
name: Test Build Windows Wheels ARM64 | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- .github/workflows/test_build_wheels_windows_arm64.yml | ||
- .github/workflows/build_wheels_windows.yml | ||
- .github/workflows/generate_binary_build_matrix.yml | ||
- tools/scripts/generate_binary_build_matrix.py | ||
workflow_dispatch: | ||
|
||
permissions: | ||
id-token: write | ||
contents: read | ||
|
||
jobs: | ||
generate-matrix: | ||
uses: ./.github/workflows/generate_binary_build_matrix.yml | ||
with: | ||
package-type: wheel | ||
os: windows-arm64 | ||
test-infra-repository: ${{ github.repository }} | ||
test-infra-ref: ${{ github.ref }} | ||
with-cuda: disable | ||
test: | ||
needs: generate-matrix | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we also want to test audio here as well? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it matter which one we use in the testing workflow? I thought this worklflow is supposed to just to check if anything starts breaking, so does it make a difference if we use audio or vision? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well if you want to test if this works across vision and audio it might make sense to test both of them here |
||
include: | ||
- repository: pytorch/vision | ||
pre-script: packaging/pre_build_script_arm64.sh | ||
smoke-test-script: test/smoke_test.py | ||
package-name: torchvision | ||
architecture: "arm64" | ||
uses: ./.github/workflows/build_wheels_windows.yml | ||
name: ${{ matrix.repository }} | ||
with: | ||
repository: ${{ matrix.repository }} | ||
ref: nightly | ||
test-infra-repository: ${{ github.repository }} | ||
test-infra-ref: ${{ github.ref }} | ||
pre-script: ${{ matrix.pre-script }} | ||
build-matrix: ${{ needs.generate-matrix.outputs.matrix }} | ||
smoke-test-script: ${{ matrix.smoke-test-script }} | ||
package-name: ${{ matrix.package-name }} | ||
trigger-event: "${{ github.event_name }}" | ||
architecture: ${{ matrix.architecture }} |
Uh oh!
There was an error while loading. Please reload this page.