Skip to content

Conversation

matteobettini
Copy link
Contributor

Vmas fooball bug should be fixed

Copy link

pytorch-bot bot commented Sep 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3178

Note: Links to docs will display an error until the docs builds have been completed.

❌ 17 New Failures, 2 Cancelled Jobs, 3 Unrelated Failures

As of commit da75c57 with merge base 8374bb4 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 30, 2025
@matteobettini
Copy link
Contributor Author

matteobettini commented Sep 30, 2025

@vmoens can you activate the vmas CI for the PR pls?

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting for the tests to complete this time

@matteobettini
Copy link
Contributor Author

We may need to add the label and rerun no?

@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Oct 13, 2025
@vmoens
Copy link
Collaborator

vmoens commented Oct 16, 2025

Merging as football is fixed but we have a new error

FAILED test/test_libs.py::TestVmas::test_vmas_seeding[simple_reference] - AssertionError: key ('agents', 'action') does not match, got mse = 0.4989
FAILED test/test_libs.py::TestVmas::test_vmas_seeding[waterfall] - AssertionError: key ('agents', 'action') does not match, got mse = 0.8571
FAILED test/test_libs.py::TestVmas::test_vmas_seeding[flocking] - AssertionError: key ('agents', 'action') does not match, got mse = 0.8473
FAILED test/test_libs.py::TestVmas::test_vmas_seeding[discovery] - AssertionError: key ('agents', 'action') does not match, got mse = 0.8666

@vmoens vmoens merged commit 94003d6 into pytorch:main Oct 16, 2025
83 of 105 checks passed
@matteobettini
Copy link
Contributor Author

Thanks!

Ah the seeding. This comes from our super cool code for setting a local torch seed, lemme see if the seeding tests still male sense

@vmoens
Copy link
Collaborator

vmoens commented Oct 16, 2025

Thanks
As always, you're blazing fast, we'll call you Claude from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants