Skip to content

portable: copy consecutive index_put_ rows in one block - #25346

Draft
psiddh wants to merge 10 commits into
pytorch:mainfrom
psiddh:npu/pr09-index-put-runs
Draft

psiddh wants to merge 10 commits into
pytorch:mainfrom
psiddh:npu/pr09-index-put-runs

Conversation

@psiddh

@psiddh psiddh commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

When the indexed rows of index_put_ are consecutive, copy them as one block instead of row by row. This is the CPU write of new K/V rows into the cache; on Qwen3 it cut the prefill CPU time per chunk from about 12 ms to about 1 ms.

Related PRs (review in order)

  1. Partitioner: run backend-contributed edge transform passes #24566 Partitioner: run backend-contributed edge transform passes
  2. Export: avoid reused lifted-constant names #24567 Export: avoid reused lifted-constant names
  3. LLM runner: select I/O contracts and accept custom buffer allocators #24568 LLM runner: select I/O contracts and accept custom buffer allocators
  4. QNN: construct partitioners from options and allocate LLM I/O in rpcmem #24569 QNN: construct partitioners from options and allocate LLM I/O in rpcmem
  5. QNN: bind delegate outputs in exported program order #24570 QNN: bind delegate outputs in exported program order
  6. QNN: never mix shared and client buffers in one graph execute #25345 QNN: never mix shared and client buffers in one graph execute
  7. Export hf_static float-cache programs and register their Python runner #24571 Export hf_static float-cache programs and register their Python runner
  8. LLM runner: validate and drive hf_static float-cache programs #24572 LLM runner: validate and drive hf_static float-cache programs
  9. Document the version-1 hf_static I/O contract #24573 Document the version-1 hf_static I/O contract
  10. portable: copy consecutive index_put_ rows in one block #25346 portable: copy consecutive index_put_ rows in one block
  11. LLM runner: never sample more logits than the model returns #25347 LLM runner: never sample more logits than the model returns
  12. hf_static v2: transposed key caches, full-length sliding caches, per-head attention #25348 hf_static v2: transposed key caches, full-length sliding caches, per-head attention
  13. LLM runner: drive hf_static v2 programs #25349 LLM runner: drive hf_static v2 programs
  14. QNN: export quantized hf_static programs in the NPU cache layout #25350 QNN: export quantized hf_static programs in the NPU cache layout
  15. Document the hf_static v2 NPU cache layout #25351 Document the hf_static v2 NPU cache layout

Each PR includes the commits of the ones above it; review only its own top commit.

Run each partitioner’s edge transforms after caller-supplied passes so backends can use the standard lowering entry point. QNN contributes its existing transforms through the new hook.
Reserve names for constant tensors already present in the exported program before lifting new constants, so methods with folded tables retain distinct constants.
Choose the registered IOManager and its logits, method names and step sizes, rejecting unknown contracts and invalid metadata. Load and reset the selected methods; route prompt tails to decode with a side-effect-free capacity check. Preserve module and I/O-buffer lifetimes and expose a backend-neutral allocator hook.
Route backend options through QnnPartitioner.from_options and register an allocator that supplies QNN shared-memory buffers through the generic IOManager hook. The LLM runner remains backend-neutral.
Encode graph output positions and restore their order at both runtime tensor-allocation entry points. Preserve context-binary order and legacy mutable outputs, and ignore malformed or overflowing position labels without throwing. This runtime change needs Qualcomm review.
On QNN SDK 2.48 an HTP execute that binds some tensors as registered rpcmem and others as plain client buffers fails (prefill DMA error 1100, decode transport error 1003) or produces wrong results; 2.50 and 2.51 runtimes run the same binding correctly. LLM runners place their caches, masks, positions and logits in rpcmem through the I/O buffer allocator, but delegate inputs and outputs that ExecuTorch plans internally (CPU-computed masks and RoPE tables, new K/V rows) stay in planned memory. When any tensor of an execute is shared, the backend now copies the remaining ones through persistent rpcmem staging buffers, one block per graph owned by the QnnManager and registered once, so each execute is all shared or all client memory. Executes without shared tensors are unchanged.

Authored with AI assistance (Metamate / agentcloud).
Move backend-neutral static-cache rewriting into the LLM extension and keep QNN partitioning and tuning in the backend. Detect sliding layers from model configuration, write every cache and counter in place on the caller buffer (export fails otherwise, since a missed write becomes full-cache CPU copies), and register a versioned runner that handles fixed chunks, padding, counters and reset. Quantized caches, sha attention and full-length sliding mode are excluded.

Authored with AI assistance (Metamate / agentcloud).
Use authoritative positions, float-cache version and dtype checks, exact buffer geometry and selected methods. Bind optional HF state outputs to existing buffers, preserve input aliases and register each concrete IOManager from its own implementation. Float-only fixtures cover reset, padding, malformed metadata and near-context tails.
Define fixed methods, cache metadata, padding, absolute counters and state-output bindings, and link the contract from the Qualcomm guide. State float-cache support and CPU-tested sliding correctness without claiming unmeasured device performance or a zero-copy Python host API.
A static-cache step writes its new rows at consecutive positions. With keys stored [1, H, D, L] each written element lands in its own position along the last dimension, so the in-place kernel issued one memcpy per element (917k per Qwen3 prefill chunk, 11.9 ms on a Galaxy S25). Rows bound for consecutive positions are now copied together, which keeps the result identical for any index order, duplicates included, and cuts that write to well under a millisecond.

Authored with AI assistance (Metamate / agentcloud).
@pytorch-bot

pytorch-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25346

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure, 4 Unclassified Failures

As of commit 5fc601c with merge base 765e973 (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant