Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25342
Note: Links to docs will display an error until the docs builds have been completed. ❌ 30 Pending, 2 Unclassified FailuresAs of commit 0906c7c with merge base 9f49fe2 ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
[ghstack-poisoned]
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 32m 0s —— View job Request Changes: the new NVFP4 dispatch has no SM89 guard, makes importing PR Review: #25342SummaryThis PR adds eager and export Backward Compatibility
API Design
Infrastructure
Testing
Performance
Code Quality
RecommendationRequest Changes Concrete fixes needed:
Needs discussion:
None of the new GPU tests run in CI, so none of the kernel or dispatch behavior in this PR is checked by automation. Review steps
|
…code down so A100 CI runs the NVFP4 kernels [ghstack-poisoned]
|
Thanks, addressed:
|
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 30m 24s —— View job Request Changes: three dispatch paths have no test, including the PR Review: #25342SummaryThis PR adds The remaining issues are mostly test coverage and one memory hotspot. The author already answered two points, the Code Quality
API Design
Infrastructure
Testing
Performance
RecommendationRequest Changes Blocking:
Non-blocking:
Review steps
|
[ghstack-poisoned]
|
Round 2:
|
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 42m 0s —— View job Request Changes: no CI job runs the default NVFP4 PR Review: #25342SummaryThis PR adds Infrastructure
Testing
Code Quality
RecommendationRequest Changes Two gaps block approval:
The other items are test robustness and cleanup. Review steps
|
[ghstack-poisoned]
|
Round 3:
|
|
@claude /pr-review |
|
Claude finished @Gasoonjia's task in 21m 59s —— View job Request Changes: PR Review: #25342SummaryThis PR adds Infrastructure
Testing
Code Quality
RecommendationRequest Changes
Review steps
|
Stack from ghstack (oldest at bottom):
Adds eager and export-time linear/embedding dispatch for
CudaNVFP4Tensor, compile-time precision and split-K selection, unit-scale integration, and a configurable prefill output dtype. Gemma CUDA weight packers accept NVFP4 tensors.PTE tests exercise serialized runtime programs, dynamic input sizes, fixed-prefill mode selection, split-K, per-output-row scales, and unit-scale behavior.
Authored with AI assistance (agentcloud).
Differential Revision: D132997584