Repository navigation
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/25177
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Cancelled Jobs, 1 PendingAs of commit 89c0ce8 with merge base 351e938 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
@claude /pr-review Please review the current revision ( |
|
Claude finished @rascani's task in 24m 37s —— View job Summary: No blockers in Detailed reviewPR Review: #25177SummaryThis PR fuses a single-consumer add, sub or mul followed by ReLU or HardTanh (including ReLU6) into one ESP-NN call:
I found no blockers and four minor issues, listed below. This PR has no earlier review findings, so there was nothing to re-check. I could not run the tests, because this job isn't allowed to execute Python. The ESP-NN kernel sources are not in the checkout, so I didn't read them. Code Quality
Testing
Backward Compatibility
RecommendationApprove. Nothing blocks merging. The most useful follow-ups are the bounds check in the wrappers and a broadcast-mul case with narrowed bounds. The emulator currently tests the new ESP-NN clamp path only with equal shapes.
|
e5cd902 to
7cf3893
Compare
7cf3893 to
ff96319
Compare
ff96319 to
ebcd154
Compare
5fe214a to
cc91377
Compare
7140f96 to
6f4aa7d
Compare
6f4aa7d to
2597b2d
Compare
2597b2d to
1f866ec
Compare
Quantize single-consumer add, subtract and multiply followed by ReLU or HardTanh, including ReLU6, at their pattern boundaries so the reference has no intermediate rounding. Fold the activation into Fused Quant output qparams and clamp bounds before ESP replacement. Reuse existing shape and arithmetic eligibility checks with the final output scale; unsupported producers retain portable execution. Forked and separately quantized activations keep their original boundaries. Clamp bounds use the producer's floating dtype to preserve BF16 and FP16 portable fallback results. Read the quantizer and FoldActivations first, then the binary lowering and schema/wrapper changes. Shared dialect and S3 implementation cases cover forks, broadcasts, saturation, fallback and narrower clamp grids, including asymmetric, positive and negative HardTanh bounds and rounding at endpoints. Authored with OpenAI Codex.
Fuse single-consumer add, subtract, or multiply followed by ReLU or HardTanh, including ReLU6, into one ESP-NN call. The quantizer observes pattern boundaries so the FQ reference has no intermediate rounding.
FoldActivationstransfers the final output qparams and clamp bounds beforeLowerToEspreuses the producer's shape and numerical eligibility checks.Forked and separately quantized activations keep their original boundaries, and unsupported producers remain portable. Clamp bounds use the producer's floating dtype to preserve FP16 and BF16 fallback results. The operator schemas, references, and wrappers carry the final clamp bounds, including both the elementwise and broadcast multiply operators introduced by #24579.
Review the quantizer and
FoldActivationsfirst, then lowering and the schema/wrapper updates. Shared dialect and S3 cases cover forks, broadcasts, saturation, fallback, asymmetric/positive/negative HardTanh bounds, and endpoint rounding. Explicit output grids exercise narrower clamp bounds for both multiply wrappers.Validation: the restacked tip passed 402 focused Python tests covering multiply, add, subtraction, binary activation fusion, numerical preparation, and the pass manager. Scoped lint passed. Earlier optimized ESP32-S3 emulator qualification passed all 55 selected multiply/activation cases with ESP-NN 1.5.0, before the Python-only binary preparation cleanup.
Authored with OpenAI Codex.