Skip to content

Replace c10:: types with std and drop redundant optional boxing in tests#20836

Open
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:variable-value-cleanup
Open

Replace c10:: types with std and drop redundant optional boxing in tests#20836
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:variable-value-cleanup

Conversation

@cyyever

@cyyever cyyever commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Use std::optional/std::string_view instead of c10:: in tests, and remove redundant std::optional boxing (plain types + implicit conversion where the target is already optional).

cc @SS-JIA @manuelcandales @digantdesai @cbilgin @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng

@pytorch-bot

pytorch-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20836

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 12 Awaiting Approval

As of commit d6355bb with merge base aceeb40 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2026
@cyyever cyyever force-pushed the variable-value-cleanup branch from b2c47fa to ec19ad7 Compare July 10, 2026 10:59
@cyyever cyyever changed the title Replace c10:: types with std and drop redundant optional boxing Replace c10:: types with std and drop redundant optional boxing in tests Jul 10, 2026
@cyyever

cyyever commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

1 similar comment
@cyyever

cyyever commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Jul 10, 2026
@cyyever cyyever force-pushed the variable-value-cleanup branch from ec19ad7 to d6355bb Compare July 10, 2026 11:23
@nil-is-all nil-is-all added module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ module: kernels Issues related to kernel libraries and utilities, and code under kernels/ module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code labels Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: kernels Issues related to kernel libraries and utilities, and code under kernels/ module: llm Issues related to LLM examples and apps, and to the extensions/llm/ code module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants