Replace c10:: types with std and drop redundant optional boxing in tests#20836
Open
cyyever wants to merge 1 commit into
Open
Replace c10:: types with std and drop redundant optional boxing in tests#20836cyyever wants to merge 1 commit into
cyyever wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20836
Note: Links to docs will display an error until the docs builds have been completed.
|
b2c47fa to
ec19ad7
Compare
Contributor
Author
|
@pytorchbot label "release notes: none" |
1 similar comment
Contributor
Author
|
@pytorchbot label "release notes: none" |
ec19ad7 to
d6355bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use std::optional/std::string_view instead of c10:: in tests, and remove redundant std::optional boxing (plain types + implicit conversion where the target is already optional).
cc @SS-JIA @manuelcandales @digantdesai @cbilgin @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng