Use std::string_view in vulkan op-test codegen#20835
Open
cyyever wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20835
Note: Links to docs will display an error until the docs builds have been completed.
|
This PR needs a
|
7130174 to
d8738ef
Compare
torchgen emits c10::string_view for string args; normalize to std::string_view at codegen time. Also drop the unused c10/util/Optional.h include in exir/verification/bindings.cpp.
d8845b1 to
d826290
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torchgen emits
c10::string_viewfor string args; normalize tostd::string_viewat codegen time (dropOLD_STRING). Also drop the unusedc10/util/Optional.hinclude inexir/verification/bindings.cpp.cc @SS-JIA @manuelcandales @digantdesai @cbilgin @larryliu0820 @JacobSzwejbka @lucylq