Skip to content

Use std::string_view in vulkan op-test codegen#20835

Open
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:header-include-cleanup
Open

Use std::string_view in vulkan op-test codegen#20835
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:header-include-cleanup

Conversation

@cyyever

@cyyever cyyever commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

torchgen emits c10::string_view for string args; normalize to std::string_view at codegen time (drop OLD_STRING). Also drop the unused c10/util/Optional.h include in exir/verification/bindings.cpp.

cc @SS-JIA @manuelcandales @digantdesai @cbilgin @larryliu0820 @JacobSzwejbka @lucylq

@pytorch-bot

pytorch-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20835

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 13 Awaiting Approval

As of commit d826290 with merge base aceeb40 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 10, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@cyyever cyyever force-pushed the header-include-cleanup branch from 7130174 to d8738ef Compare July 10, 2026 10:56
@cyyever cyyever requested a review from SS-JIA as a code owner July 10, 2026 10:56
@cyyever cyyever changed the title Remove unused c10/portable string_view and optional includes Drop c10::string_view usage and dead c10/portable includes Jul 10, 2026
@nil-is-all nil-is-all added module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ module: runtime Issues related to the core runtime and code under runtime/ labels Jul 10, 2026
torchgen emits c10::string_view for string args; normalize to std::string_view at codegen time. Also drop the unused c10/util/Optional.h include in exir/verification/bindings.cpp.
@cyyever cyyever force-pushed the header-include-cleanup branch from d8845b1 to d826290 Compare July 11, 2026 01:52
@cyyever cyyever changed the title Drop c10::string_view usage and dead c10/portable includes Use std::string_view in vulkan op-test codegen Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: runtime Issues related to the core runtime and code under runtime/ module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants