Build and install cmsis_nn pybinds with executorch#20531
Open
Erik-Lundell wants to merge 2 commits into
Open
Conversation
The package is not available on pypi, and is needed aot. Therefore, add it as a BuiltExtension in setup.py, and wire the cmake up to build it by default with the pybind.cmake preset, that is used when building the executorch wheel. A pip installation of cmsis_nn can still be used in backends.cortex_m.library.cmsis_nn as a backup. Tested in all wheel smoke tests. Additionally: - Move cmsis_nn build into the cortex_m build folder - Remove git+pip cmsis_nn install path, deprecating the --disable-cortex-m-deps flag in setup.sh - Remove pyproject.toml additional dependencies [cortex_m], since cmsis_nn is now included with executorch. - CMSIS-NN requires pybind11 as a python dependency. From a local test, the new dependency adds - 5 sec to a configure time of ~15s - 3 sec to a build time of ~10 min Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Idb79e37dd1cf28f351062e0181140a50a8e7cae4
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20531
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Unrelated Failures, 4 Unclassified FailuresAs of commit cd8a1e1 with merge base 6021a58 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: Ia9f9239e0a19b47a4a8480b86693a5f9236beff5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package is not available on pypi, and is needed aot. Therefore, add it as a BuiltExtension in setup.py, and wire the cmake up to build it by default with the pybind.cmake preset, that is used when building the executorch wheel.
A pip installation of cmsis_nn can still be used in backends.cortex_m.library.cmsis_nn as a backup.
Tested in all wheel smoke tests.
Additionally:
From a local test, the new dependency adds
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani