Fix buck dep for test_permute_optimization_passes (#20497)#20497
Fix buck dep for test_permute_optimization_passes (#20497)#20497digantdesai wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20497
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 2 Unrelated FailuresAs of commit e4ebbba with merge base 45a14b9 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4175a68 to
229a385
Compare
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109619313. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Fixes Buck build/test configuration for backends/transforms/test/test_permute_optimization_passes.py, which now imports to_edge / EdgeCompileConfig from executorch.exir and therefore requires the //executorch/exir:lib target (the owner of exir/__init__.py) to be present in the test’s deps.
Changes:
- Add missing
//executorch/exir:libdependency to thetest_permute_optimization_passesBuckruntime.python_testtarget.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary: Pull Request resolved: pytorch#20497 D109300695 (GitHub PR pytorch#19873) added a new test `test_postpone_permute_with_symbolic_shapes` that imports `to_edge` and `EdgeCompileConfig` from `executorch.exir`, but the `test_permute_optimization_passes` buck test target was never updated to depend on `//executorch/exir:lib` (the owner of `executorch/exir/__init__.py`). As a result the entire test module failed to import (`Failed to import test module: test_permute_optimization_passes`), turning every test in the module into a land-blocking CRITICAL signal on the diff train. Add the missing `//executorch/exir:lib` dep to both the `fbcode` and `xplat` copies of `backends/transforms/targets.bzl` so the two mirrors stay in sync. Reviewed By: Gasoonjia Differential Revision: D109619313
229a385 to
e4ebbba
Compare
Summary:
D109300695 (GitHub PR #19873) added a new test
test_postpone_permute_with_symbolic_shapesthat importsto_edgeandEdgeCompileConfigfromexecutorch.exir, but thetest_permute_optimization_passesbuck test target was never updated to depend on//executorch/exir:lib(the owner ofexecutorch/exir/__init__.py). As a result the entire test module failed to import (Failed to import test module: test_permute_optimization_passes), turning every test in the module into a land-blocking CRITICAL signal on the diff train.Add the missing
//executorch/exir:libdep to both thefbcodeandxplatcopies ofbackends/transforms/targets.bzlso the two mirrors stay in sync.Reviewed By: Gasoonjia
Differential Revision: D109619313