Skip to content

Arm backend: Add TOSA binary op visitors#20479

Open
SaoirseARM wants to merge 3 commits into
pytorch:mainfrom
SaoirseARM:toupstream/bin_node
Open

Arm backend: Add TOSA binary op visitors#20479
SaoirseARM wants to merge 3 commits into
pytorch:mainfrom
SaoirseARM:toupstream/bin_node

Conversation

@SaoirseARM

@SaoirseARM SaoirseARM commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Running the cast pass first normalizes constant buffers while the graph is still Edge ATen, so ExirToTosaPass only sees int32 buffer metadata and emits TOSA-compatible ops.
  • Small refactor of ExirToTosaPass

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

- Run ExirToTosaPass after int64 cleanup.
- Small refactor of ExirToTosaPass

Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
@pytorch-bot

pytorch-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20479

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures, 5 Unrelated Failures

As of commit b8522b0 with merge base 252f57c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 24, 2026
@SaoirseARM

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 24, 2026
@SaoirseARM

Copy link
Copy Markdown
Collaborator Author

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label Jun 24, 2026

@zingo zingo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if tests are OK, just make sure buck2 stuff don't need to be updated. You can just ask codex/claude

@zingo

zingo commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

FAILED backends/arm/test/misc/test_vgf_backend.py::test_vgf_compile_failure_includes_repro_command_and_copies_tosa

Is known and a fix has been merged, just rebase or double check to there are no others files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants