Skip to content

drop redundant TARGETS files that duplicate sister BUCK files (#20403)#20403

Merged
meta-codesync[bot] merged 1 commit into
mainfrom
export-D109082060
Jun 23, 2026
Merged

drop redundant TARGETS files that duplicate sister BUCK files (#20403)#20403
meta-codesync[bot] merged 1 commit into
mainfrom
export-D109082060

Conversation

@bigfootjon

@bigfootjon bigfootjon commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary:

Initial chunk of fbcode/executorch TARGETS->BUCK migration. Removes 40
TARGETS files where:

  • 7 are byte-identical to their sister BUCK file, OR
  • 33 contain only a no-arg define_common_targets() call matching
    a sister BUCK that also calls define_common_targets() with no args

In both cases fbcode falls through to the BUCK file (via
name_v2 = TARGETS,BUCK) and evaluates the exact same content it did
before. Any TARGETS that passes any argument to define_common_targets
(positional or keyword) is intentionally excluded — those are the
is_fbcode = True cases that need a separate, more careful treatment.

Reviewed By: mzlee

Differential Revision: D109082060

@pytorch-bot

pytorch-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20403

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 1 Unrelated Failure, 3 Unclassified Failures

As of commit 00f371f with merge base 6f6225c (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 18, 2026
@meta-codesync

meta-codesync Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082060.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes redundant fbcode TARGETS files that duplicate their sibling BUCK files as part of the ongoing TARGETS→BUCK migration, relying on the name_v2 = TARGETS,BUCK fallback to keep behavior unchanged.

Changes:

  • Deleted TARGETS files that were byte-identical to the corresponding BUCK file.
  • Deleted TARGETS files that only performed a no-arg define_common_targets() call that already exists in the corresponding BUCK.
  • No functional build target changes intended; this is a cleanup/deduplication step.

Reviewed changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
schema/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
schema/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/platform/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/platform/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/testing_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/testing_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/core/exec_aten/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/backend/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
runtime/backend/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/prim_ops/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/portable/cpu/util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/portable/cpu/util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/optimized/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
kernels/optimized/cpu/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/threadpool/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/threadpool/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/testing_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/testing_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/tensor/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/tensor/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/runner_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/pytree/aten_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/pytree/aten_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/image/benchmark/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/cuda/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/aten_util/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
extension/aten_util/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
examples/qualcomm/executor_runner/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
examples/devtools/example_runner/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
configurations/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
codegen/test/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
backends/qualcomm/builders/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()
backends/qualcomm/aot/wrappers/TARGETS Removed redundant TARGETS; BUCK already calls define_common_targets()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Summary:
Pull Request resolved: #20403

Initial chunk of fbcode/executorch TARGETS->BUCK migration. Removes 40
TARGETS files where:

  - 7 are byte-identical to their sister BUCK file, OR
  - 33 contain only a no-arg `define_common_targets()` call matching
    a sister BUCK that also calls `define_common_targets()` with no args

In both cases fbcode falls through to the BUCK file (via
`name_v2 = TARGETS,BUCK`) and evaluates the exact same content it did
before. Any TARGETS that passes any argument to define_common_targets
(positional or keyword) is intentionally excluded — those are the
`is_fbcode = True` cases that need a separate, more careful treatment.

Reviewed By: mzlee

Differential Revision: D109082060
@meta-codesync meta-codesync Bot changed the title drop redundant TARGETS files that duplicate sister BUCK files drop redundant TARGETS files that duplicate sister BUCK files (#20403) Jun 22, 2026
@digantdesai

Copy link
Copy Markdown
Contributor

Running Trunk jobs as well to make sure things are good.

@meta-codesync meta-codesync Bot merged commit 65bc0ca into main Jun 23, 2026
515 of 528 checks passed
@meta-codesync meta-codesync Bot deleted the export-D109082060 branch June 23, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants