Skip to content

Fix spotlessKotlinCheck formatting for makeExecutorchException call#20211

Merged
psiddh merged 2 commits into
pytorch:mainfrom
psiddh:fix-spotless-module-kt
Jun 11, 2026
Merged

Fix spotlessKotlinCheck formatting for makeExecutorchException call#20211
psiddh merged 2 commits into
pytorch:mainfrom
psiddh:fix-spotless-module-kt

Conversation

@psiddh

@psiddh psiddh commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

ktfmt requires each argument on its own line with a trailing comma when the call is split across lines.

ktfmt requires each argument on its own line with a trailing comma
when the call is split across lines.

This was authored with assistance from Claude.
Copilot AI review requested due to automatic review settings June 11, 2026 00:11
@psiddh psiddh requested a review from kirklandsign as a code owner June 11, 2026 00:11
@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20211

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit cee6a3d with merge base 129c687 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Kotlin formatting in the Android Module wrapper to satisfy ktfmt/spotlessKotlinCheck requirements for multi-line argument lists.

Changes:

  • Reformats the makeExecutorchException(...) call in Module.loadMethod() to put each argument on its own line.
  • Adds a trailing comma to the last argument for a multi-line call, matching ktfmt expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@psiddh psiddh closed this Jun 11, 2026
@psiddh psiddh deleted the fix-spotless-module-kt branch June 11, 2026 00:28
@psiddh psiddh restored the fix-spotless-module-kt branch June 11, 2026 00:29
@psiddh psiddh reopened this Jun 11, 2026
@psiddh psiddh merged commit bd7426d into pytorch:main Jun 11, 2026
177 of 179 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants