Skip to content

Arm backend: Replace VkQueueWaitIdle with fences#20186

Merged
wwwind merged 2 commits into
pytorch:mainfrom
wwwind:vgf_fence
Jun 10, 2026
Merged

Arm backend: Replace VkQueueWaitIdle with fences#20186
wwwind merged 2 commits into
pytorch:mainfrom
wwwind:vgf_fence

Conversation

@wwwind

@wwwind wwwind commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Use fences to wait for the submitted VGF command buffer instead of calling vkQueueWaitIdle(). This avoids stalling the whole queue and only waits for the work submitted by the backend.

Create the execution fence once during VGF setup and reuse it across execute_vgf() calls by resetting it before each submission. Keep the one-shot fence helper for temporary setup submissions.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

Use fences to wait for the submitted VGF command buffer instead of
calling vkQueueWaitIdle(). This avoids stalling the whole queue and only
waits for the work submitted by the backend.

Create the execution fence once during VGF setup and reuse it across
execute_vgf() calls by resetting it before each submission. Keep the
one-shot fence helper for temporary setup submissions.

Signed-off-by: Elena Zhelezina <elena.zhelezina@arm.com>
Change-Id: I628680dd530738284aa5be3e356c242d2a40ca6b
@wwwind wwwind requested a review from digantdesai as a code owner June 10, 2026 15:30
@pytorch-bot

pytorch-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20186

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unclassified Failures

As of commit ca52cb4 with merge base cec0814 (image):

NEW FAILURE - The following job has failed:

UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:

  • Check Labels / Check labels (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    Process completed with exit code 1.
  • Labeler / label (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)
    Requires authentication

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2026
@wwwind wwwind added ciflow/trunk release notes: arm Changes to the ARM backend delegate module: arm Issues related to arm backend labels Jun 10, 2026

@robell robell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved our side.

@zingo zingo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge if tests pass

@wwwind

wwwind commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

the new failure is unrelevant. fails to download llvm

@wwwind wwwind merged commit e0be283 into pytorch:main Jun 10, 2026
482 of 495 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants