Skip to content

Revert "Avoid duplicate ops registration in macOS executor_runner" #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metascroy merged 1 commit into from
Jun 2, 2026
Merged

Revert "Avoid duplicate ops registration in macOS executor_runner" #19949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backends/apple/coreml/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,12 @@ if(APPLE)

executorch_target_link_options_shared_lib(coremldelegate)

if(EXECUTORCH_COREML_BUILD_EXECUTOR_RUNNER)
target_link_libraries(
coremldelegate PRIVATE portable_ops_lib portable_kernels
)
endif()

target_compile_options(
coremldelegate PRIVATE -fobjc-arc -fno-exceptions -x objective-c++
-Wno-null-character -Wno-receiver-expr
Expand Down
4 changes: 4 additions & 0 deletions tools/cmake/preset/default.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,10 @@ define_overridable_option(
define_overridable_option(
EXECUTORCH_BUILD_VGF "Build the Arm VGF backend" BOOL OFF
)
define_overridable_option(
EXECUTORCH_COREML_BUILD_EXECUTOR_RUNNER "Build CoreML executor runner." BOOL
OFF
)
define_overridable_option(
EXECUTORCH_BUILD_WASM "Build the ExecuTorch JavaScript API" BOOL OFF
)
Expand Down
1 change: 1 addition & 0 deletions tools/cmake/preset/macos.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ include(${PROJECT_SOURCE_DIR}/tools/cmake/preset/apple_common.cmake)
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_EVALUE_UTIL ON)
set_overridable_option(EXECUTORCH_BUILD_EXTENSION_RUNNER_UTIL ON)
set_overridable_option(EXECUTORCH_BUILD_EXECUTOR_RUNNER ON)
set_overridable_option(EXECUTORCH_COREML_BUILD_EXECUTOR_RUNNER ON)
Loading