Remove google-java-format from CI lint infrastructure#19831
Remove google-java-format from CI lint infrastructure#19831kirklandsign wants to merge 1 commit into
google-java-format from CI lint infrastructure#19831Conversation
Summary: All Android source files in ExecuTorch have been converted from Java to Kotlin as part of the ongoing Java-to-Kotlin migration. The `google-java-format` linter and CI job are no longer needed since there are no Java files left to format. This removes: - The `google-java-format` binary installation from the Docker linter image (`.ci/docker/common/install_linter.sh`) - The `android-java-format` CI job from the lint workflow (`.github/workflows/lint.yml`) Differential Revision: D106575515
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19831
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 7 Cancelled Jobs, 3 Unrelated FailuresAs of commit 37469ab with merge base d366f43 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106575515. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
Removes the google-java-format installation from the linter Docker image and deletes the dedicated Android Java formatting job from the GitHub Actions lint workflow, based on the assumption that the Android codebase has completed migration from Java to Kotlin.
Changes:
- Delete the
android-java-formatjob from.github/workflows/lint.yml. - Remove
google-java-formatbinary installation from.ci/docker/common/install_linter.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/lint.yml |
Removes the CI job that checked formatting of Android/benchmark .java sources. |
.ci/docker/common/install_linter.sh |
Stops installing google-java-format into the linter Docker image. |
Comments suppressed due to low confidence (1)
.github/workflows/lint.yml:128
- This PR removes the
android-java-formatlint job under the assumption that there are no Java sources left, but there are still.javafiles in the repo (e.g.extension/android/executorch_android/src/main/java/org/pytorch/executorch/Module.java,Tensor.java, andextension/benchmark/android/benchmark/app/src/androidTest/java/org/pytorch/minibench/ExampleInstrumentedTest.java). Removing the job will drop formatting enforcement for these remaining Java files. Either (a) convert/remove the remaining.javafiles as part of the migration, or (b) keep (or replace) a Java formatting check in CI until they are gone.
link-check:
uses: ./.github/workflows/_link_check.yml
with:
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary:
All Android source files in ExecuTorch have been converted from Java to Kotlin as part of the ongoing Java-to-Kotlin migration. The
google-java-formatlinter and CI job are no longer needed since there are no Java files left to format.This removes:
google-java-formatbinary installation from the Docker linter image (.ci/docker/common/install_linter.sh)android-java-formatCI job from the lint workflow (.github/workflows/lint.yml)Differential Revision: D106575515