Skip to content

Remove google-java-format from CI lint infrastructure#19831

Open
kirklandsign wants to merge 1 commit into
mainfrom
export-D106575515
Open

Remove google-java-format from CI lint infrastructure#19831
kirklandsign wants to merge 1 commit into
mainfrom
export-D106575515

Conversation

@kirklandsign
Copy link
Copy Markdown
Contributor

Summary:
All Android source files in ExecuTorch have been converted from Java to Kotlin as part of the ongoing Java-to-Kotlin migration. The google-java-format linter and CI job are no longer needed since there are no Java files left to format.

This removes:

  • The google-java-format binary installation from the Docker linter image (.ci/docker/common/install_linter.sh)
  • The android-java-format CI job from the lint workflow (.github/workflows/lint.yml)

Differential Revision: D106575515

Summary:
All Android source files in ExecuTorch have been converted from Java to Kotlin as part of the ongoing Java-to-Kotlin migration. The `google-java-format` linter and CI job are no longer needed since there are no Java files left to format.

This removes:
- The `google-java-format` binary installation from the Docker linter image (`.ci/docker/common/install_linter.sh`)
- The `android-java-format` CI job from the lint workflow (`.github/workflows/lint.yml`)

Differential Revision: D106575515
Copilot AI review requested due to automatic review settings May 27, 2026 23:06
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19831

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 7 Cancelled Jobs, 3 Unrelated Failures

As of commit 37469ab with merge base d366f43 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 27, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 27, 2026

@kirklandsign has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106575515.

@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the google-java-format installation from the linter Docker image and deletes the dedicated Android Java formatting job from the GitHub Actions lint workflow, based on the assumption that the Android codebase has completed migration from Java to Kotlin.

Changes:

  • Delete the android-java-format job from .github/workflows/lint.yml.
  • Remove google-java-format binary installation from .ci/docker/common/install_linter.sh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/lint.yml Removes the CI job that checked formatting of Android/benchmark .java sources.
.ci/docker/common/install_linter.sh Stops installing google-java-format into the linter Docker image.
Comments suppressed due to low confidence (1)

.github/workflows/lint.yml:128

  • This PR removes the android-java-format lint job under the assumption that there are no Java sources left, but there are still .java files in the repo (e.g. extension/android/executorch_android/src/main/java/org/pytorch/executorch/Module.java, Tensor.java, and extension/benchmark/android/benchmark/app/src/androidTest/java/org/pytorch/minibench/ExampleInstrumentedTest.java). Removing the job will drop formatting enforcement for these remaining Java files. Either (a) convert/remove the remaining .java files as part of the migration, or (b) keep (or replace) a Java formatting check in CI until they are gone.
  link-check:
    uses: ./.github/workflows/_link_check.yml
    with:
      ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants