Qualcomm AI Engine Direct - Adding QNN backend support for var core ATen ops#19722
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19722
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit c54f8ca with merge base af92b60 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "release notes: qualcomm" |
|
|
Contributor
Author
|
|
Contributor
|
|
psiddh
reviewed
May 28, 2026
psiddh
approved these changes
May 28, 2026
Contributor
Author
Contributor
|
Lint failures on the PR, pls check |
Contributor
Author
Resolved now, thanks |
Contributor
Author
|
Hi, can we merge this pr or did you want any other changes? |
Contributor
|
Lgtm, I will merge it once the CI passes basic sanity tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for the core ATen ops
var.correctionandvar.dimvia a decomposition pass using:Where
var.correctionis an optional scalar(default=1)and forvar.dimunbiased=True -> correction=1, unbiased=False -> correction=0.Also added a couple of test cases for the
select_scatterop per a suggestion in another pr.Test plan
cc @cccclai @cbilgin @abhinaykukkadapu