NXP backend - added support for aten.conv2d using the new Neutron flow

[novak-vaclav]

Summary

Added support for aten.conv2d using new Neutron flow.

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

cc @robert-kalmar @JakeStevens @digantdesai @rascani @MartinPavella

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19717

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• [ROCm] MI350 CI runner label rename: rebase PRs using old linux.rocm.gpu.gfx950.* labels

❌ 3 New Failures, 2 Unrelated Failures

As of commit dc7cd68 with merge base 252f57c ():

NEW FAILURES - The following jobs have failed:

• pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
  RuntimeError: Command docker exec -t 49529b93e59d79cd71ee1d3d3127736c358deef01ccfce38afd64069d9fb8318 /exec failed with exit code 137
• pull / unittest / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 0b215dc14c3179e50c5645ca0bf3176be4dcc360b62b70f3ef215ce0afb5b923 /exec failed with exit code 1
• pull / unittest-editable / linux / linux-job (gh)
  RuntimeError: Command docker exec -t c59111d8e87353ed3b620d7a26409251fc721b6db9362a8954659e6f81183c6b /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / unittest / macos / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• pull / unittest-editable / macos / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[novak-vaclav]

@pytorchbot label "module: nxp"

[novak-vaclav]

@pytorchbot label "release notes: nxp"

[novak-vaclav]

Please also review @MartinPavella @roman-janik-nxp @StrycekSimon. Thank you 😄

[Copilot]

Pull request overview

Adds aten.conv2d delegation coverage for the NXP Neutron “new flow” and expands the NXP backend test suite to validate delegation behavior and (where possible) numerical correctness.

Changes:

• Add a new-flow support-check path in the convolution converter and tighten failure behavior when group conv decomposition is missing.
• Add extensive new pytest coverage for conv2d delegation/non-delegation scenarios under the new Neutron flow (including depthwise and edge/bounds cases, plus targeted xfails for known issues).
• Improve NPU-vs-CPU mismatch reporting in the output comparator by including the max diff in the assertion message.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
backends/nxp/tests/model_output_comparator.py	Improves assertion failure message for output mismatches.
backends/nxp/tests/ir/converter/node_converter/test_conv_converter.py	Adds a large new test suite for conv2d under the new Neutron flow, including delegation checks and known-issue xfails.
backends/nxp/backend/ir/converter/node_converters/ops_converters/convolution_converter.py	Introduces new-flow target support checks and adjusts convolution argument handling / group-conv behavior.
backends/nxp/aten_passes/split_group_convolution.py	Updates group-conv splitting pass to handle optional bias and propagate FakeTensor meta safely.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[novak-vaclav]

Fixed the issues found by Copilot.

[MartinPavella]

Will review the rest of test_conv_converter tomorrow.

[MartinPavella]

@novak-vaclav please take a look at this issue: https://jira.sw.nxp.com/browse/EIEX-809
Is it relevant/applicable?

[linux-foundation-easycla]

• ❌ - login: @novak-vaclav / name: Vaclav Novak. The commit (3459bfd, dc7cd68) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please visit our EasyCLA portal and chat with our support bot.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

[novak-vaclav]

Fixed issues mentioned by @MartinPavella and updated the tests so they are based on Neutron SW 3.1.2.
@MartinPavella Do you need me to rebase it onto your Neutron SW 3.1.2 update branch?

The support for padding mode same / valid will be solved in a separate issue.

[novak-vaclav]

Fixed issues mentioned by Copilot.

Note: I am not using the use_qat pytest fixture in test_conv_converter deliberately, because sometimes I need to mark a test configuration with xfail when qat=False and sometimes when qat=True

[novak-vaclav]

Now I see I will have to rebase onto the Neutron SW 3.1.2 branch, will do

[MartinPavella]

LGTM 👍🏻
I will approve after you rebase to the 3.1.2 PR

[Copilot]

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

backends/nxp/tests/ir/converter/node_converter/test_conv_converter.py:1

• AllCloseOutputComparator is imported from executorch.backends.nxp.tests.nsys_testing, but in this PR other test modules import output comparators from executorch.backends.nxp.tests.model_output_comparator. If nsys_testing doesn’t define/re-export AllCloseOutputComparator, this will fail at import time. Import the comparator from its actual module (or re-export it explicitly in nsys_testing/a shared test utilities module) to keep imports consistent and avoid test collection errors.
  examples/nxp/setup.sh:1
• The --index-url value is unquoted; if EIQ_PYPI_URL ever contains special characters (or is empty/oddly formatted), word-splitting can break the command. Quote the variable (\"${EIQ_PYPI_URL}\") to make the script more robust.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

[MartinPavella]

@novak-vaclav I noticed that the job was killed after 90 minutes. Tested 2 times, the timeout triggered during completely different tests and timestamps suggest that nothing froze. Seems like the added convolution tests just increased the duration of the job to over 90 minutes.

I increased the limit to 120 minutes in the last commit.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

[novak-vaclav]

Rebased onto current main, (hopefully) resolved all test issues. Let's see

[novak-vaclav]

Hopefully now it will all be resolved.

[novak-vaclav]

Internal tests are passing. The opensource CI test failures do not seem to be related.