Add XNNPACK, MobileNetV2, MobileBERT, Llama, ResNet18 to RISC-V testing matrix#19617
Add XNNPACK, MobileNetV2, MobileBERT, Llama, ResNet18 to RISC-V testing matrix#19617luhenry wants to merge 8 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19617
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 38 Unrelated Failures, 11 Unclassified FailuresAs of commit 4b5e42e with merge base 7355d7b ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc @rascani @mergennachin, and @GregoryComer @digantdesai for XNNPACK |
This PR needs a
|
|
|
||
| bash .ci/scripts/test_riscv_qemu.sh | ||
| export GCC_VERSION=${{ inputs.gcc-version }} | ||
| bash .ci/scripts/test_riscv_qemu.sh --model="${{ inputs.model }}" ${{ inputs.xnnpack && '--xnnpack' }} ${{ inputs.quantize && '--quantize' }} |
There was a problem hiding this comment.
The boolean conditionals need an "or empty string."
${{ inputs.xnnpack && '--xnnpack' || '' }} ${{ inputs.quantize && '--quantize' || '' }}
Alternatively, the script could take --xnnpack=true/false --quantize=true/false
| test-riscv: | ||
| name: test-riscv | ||
| uses: ./.github/workflows/_test_riscv.yml | ||
| strategy: |
There was a problem hiding this comment.
We typically also set fail-fast: false
| quantize: ${{ matrix.quantize }} | ||
| # XNNPACK requires GCC 14+ | ||
| gcc-version: ${{ matrix.xnnpack && 14 }} | ||
| docker-image: ${{ matrix.xnnpack && 'ci-image:executorch-ubuntu-24.04-gcc14' }} |
There was a problem hiding this comment.
gcc-version: ${{ matrix.xnnpack && 14 || 11 }}
docker-image: ${{ matrix.xnnpack && 'ci-image:executorch-ubuntu-24.04-gcc14' || 'ci-image:executorch-ubuntu-22.04-gcc11' }}
Summary
This is the continuation of #19399 and #19521, to deliver on Phase 2 of #18991
Test plan
This code is exclusively test code. Everything works out of the box, and CI will validate.