Convert unconditional GTEST_SKIP tests to DISABLED_ prefix#19355
Convert unconditional GTEST_SKIP tests to DISABLED_ prefix#19355rascani wants to merge 2 commits intopytorch:mainfrom
Conversation
Summary: A number of kernel unit tests are skipped unconditionally, with the very first statement is `GTEST_SKIP() << "Dynamic shape not supported";`. These tests therefore emit a `SKIPPED` result on every invocation while the feature is unimplemented. The googletest recommended idiom for this case is the `DISABLED_` name prefix: - The test is still **compiled**, so the documenting body cannot rot. - The test is **not executed** by gtest at all (no result is emitted). This commit applies that conversion mechanically to every unconditionally-skipped GTest in the ExecuTorch tree. Disabled tests can still be opted into on demand via gtest's `--gtest_also_run_disabled_tests` flag. Differential Revision: D104126199
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19355
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 17 Unrelated FailuresAs of commit cae64d1 with merge base af90130 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104126199. |
This PR needs a
|
The DISABLED_ rename in this PR pushed two TEST_F invocations past the 80-column limit. clang-format wants them split across three lines.
|
@rascani has imported this pull request. If you are a Meta employee, you can view this in D104126199. |
Summary:
A number of kernel unit tests are skipped unconditionally, with the very first statement is
GTEST_SKIP() << "Dynamic shape not supported";. These tests therefore emit aSKIPPEDresult on every invocation while the feature isunimplemented.
The googletest recommended idiom for this case is the
DISABLED_nameprefix:
This commit applies that conversion mechanically to every
unconditionally-skipped GTest in the ExecuTorch tree.
Disabled tests can still be opted into on demand via gtest's
--gtest_also_run_disabled_testsflag.Differential Revision: D104126199