Skip to content

Convert unconditional GTEST_SKIP tests to DISABLED_ prefix#19355

Open
rascani wants to merge 2 commits intopytorch:mainfrom
rascani:export-D104126199
Open

Convert unconditional GTEST_SKIP tests to DISABLED_ prefix#19355
rascani wants to merge 2 commits intopytorch:mainfrom
rascani:export-D104126199

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented May 7, 2026

Summary:
A number of kernel unit tests are skipped unconditionally, with the very first statement is GTEST_SKIP() << "Dynamic shape not supported";. These tests therefore emit a SKIPPED result on every invocation while the feature is
unimplemented.

The googletest recommended idiom for this case is the DISABLED_ name
prefix:

  • The test is still compiled, so the documenting body cannot rot.
  • The test is not executed by gtest at all (no result is emitted).

This commit applies that conversion mechanically to every
unconditionally-skipped GTest in the ExecuTorch tree.

Disabled tests can still be opted into on demand via gtest's
--gtest_also_run_disabled_tests flag.

Differential Revision: D104126199

Summary:
A number of kernel unit tests are skipped unconditionally, with the very first statement is `GTEST_SKIP() << "Dynamic shape not supported";`. These tests therefore emit a `SKIPPED` result on every invocation while the feature is
unimplemented.

The googletest recommended idiom for this case is the `DISABLED_` name
prefix:

- The test is still **compiled**, so the documenting body cannot rot.
- The test is **not executed** by gtest at all (no result is emitted).

This commit applies that conversion mechanically to every
unconditionally-skipped GTest in the ExecuTorch tree.

Disabled tests can still be opted into on demand via gtest's
`--gtest_also_run_disabled_tests` flag.

Differential Revision: D104126199
@rascani rascani requested a review from manuelcandales as a code owner May 7, 2026 00:30
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19355

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 17 Unrelated Failures

As of commit cae64d1 with merge base af90130 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 7, 2026

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104126199.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

The DISABLED_ rename in this PR pushed two TEST_F invocations past the
80-column limit. clang-format wants them split across three lines.
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 7, 2026

@rascani has imported this pull request. If you are a Meta employee, you can view this in D104126199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant