Skip to content

Add 3D (NCW) channels-last dim_order support to Neutron runtime#19341

Open
JakeStevens wants to merge 1 commit intopytorch:mainfrom
JakeStevens:export-D102862305
Open

Add 3D (NCW) channels-last dim_order support to Neutron runtime#19341
JakeStevens wants to merge 1 commit intopytorch:mainfrom
JakeStevens:export-D102862305

Conversation

@JakeStevens
Copy link
Copy Markdown
Contributor

Summary:
Although 3dim dim order is not supported pytorch, it actually is properly supported within the NXP backend's implementation.

The only issue is within the runtime, which forces the check to four dimensions.

This PR relaxes and supports 3D.

Differential Revision: D102862305

Summary:
Although 3dim dim order is not supported pytorch, it actually *is* properly supported within the NXP backend's implementation.

The only issue is within the runtime, which forces the check to four dimensions.

This PR relaxes and supports 3D.

Differential Revision: D102862305
@JakeStevens JakeStevens requested a review from robert-kalmar as a code owner May 6, 2026 20:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19341

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 12 Cancelled Jobs, 21 Unrelated Failures

As of commit 1a79957 with merge base cdcc915 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 6, 2026

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102862305.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Collaborator

@jirioc jirioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. Note that sometimes the transpositions are done by the neutron instead of the backend (scheduled by AoT), so I you need to make sure that that part is also compatible with 3D.

@MartinPavella
Copy link
Copy Markdown
Collaborator

LGTM. But perhaps some test with a simple 3D channels last dim order model would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants