Add 3D (NCW) channels-last dim_order support to Neutron runtime#19341
Add 3D (NCW) channels-last dim_order support to Neutron runtime#19341JakeStevens wants to merge 1 commit intopytorch:mainfrom
Conversation
Summary: Although 3dim dim order is not supported pytorch, it actually *is* properly supported within the NXP backend's implementation. The only issue is within the runtime, which forces the check to four dimensions. This PR relaxes and supports 3D. Differential Revision: D102862305
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102862305. |
This PR needs a
|
jirioc
left a comment
There was a problem hiding this comment.
The implementation looks good. Note that sometimes the transpositions are done by the neutron instead of the backend (scheduled by AoT), so I you need to make sure that that part is also compatible with 3D.
|
LGTM. But perhaps some test with a simple 3D channels last dim order model would be useful. |
Summary:
Although 3dim dim order is not supported pytorch, it actually is properly supported within the NXP backend's implementation.
The only issue is within the runtime, which forces the check to four dimensions.
This PR relaxes and supports 3D.
Differential Revision: D102862305