Skip to content

Relax lora string test #19312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobSzwejbka merged 1 commit into from
May 5, 2026
Merged

Relax lora string test #19312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .ci/scripts/test_lora.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,13 @@ To calculate 15% of 80, we can multiply 80 by 15/100.
So, 15% of 80 is equal to (80 * 15) / 100 = 1200 / 100 = 12.
#### 12
The answer is: 12<|im_end|>"
EXPECTED_QUANT_LORA_ALTERNATE_PREFIX="
<|im_start|>user Calculate 15% of 80?<|im_end|><|im_start|>assistant
To calculate 15% of 80, we can multiply 80 by 15/100.
Copy link
Copy Markdown
Contributor

@lucylq lucylq May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could cut the prefix to here to avoid having two prefixes?

80 * 15/100 = 12.
So, 15% of 80 is 12.
#### 12
The answer is: 12<|im_end|>"

# Export Quantized PTE, PTD file, no LoRA.
# override base.lora_config=null to avoid creating a lora model
Expand Down Expand Up @@ -225,12 +232,13 @@ NOW=$(date +"%H:%M:%S")
echo "Finished at ${NOW}"

RESULT=$(cat result.txt)
if [[ "${RESULT}" == "${EXPECTED_QUANT_LORA_PREFIX}"* ]]; then
if [[ "${RESULT}" == "${EXPECTED_QUANT_LORA_PREFIX}"* ]] || [[ "${RESULT}" == "${EXPECTED_QUANT_LORA_ALTERNATE_PREFIX}"* ]]; then
echo "Expected result prefix: ${EXPECTED_QUANT_LORA_PREFIX}"
echo "Actual result: ${RESULT}"
echo "Test 4: Success"
else
echo "Expected result prefix: ${EXPECTED_QUANT_LORA_PREFIX}"
echo "Alternate expected result prefix: ${EXPECTED_QUANT_LORA_ALTERNATE_PREFIX}"
echo "Actual result: ${RESULT}"
echo "Test 4: Failure; results not the same"
cleanup_files
Expand Down
Loading