Add xplat cxx_binary target for bench_sdpa#18705
Add xplat cxx_binary target for bench_sdpa#18705kimishpatel wants to merge 14 commits intogh/kimishpatel/225/basefrom
Conversation
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18705
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 12 Pending, 3 Unrelated FailuresAs of commit 0d7815a with merge base 1debeb6 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
submitted by accident, not meant to land immedidately |
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 371787365 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 372451169 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 373439502 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 374228874 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 374666324 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 375300140 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 375388935 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 376092494 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 377506496 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 377591903 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 377697714 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 377749269 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/) [ghstack-poisoned]
Pull Request resolved: #18705 Add non_fbcode_target cxx_binary so bench_sdpa can be built via the xplat build path (e.g. for on-device testing). Wrap the existing cpp_benchmark in fbcode_target to avoid name collision between the fbcode benchmark target and the xplat binary target. ghstack-source-id: 378132054 @exported-using-ghexport Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Stack from ghstack (oldest at bottom):
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
Differential Revision: D96044315