Skip to content

Add xplat cxx_binary target for bench_sdpa#18705

Open
kimishpatel wants to merge 14 commits intogh/kimishpatel/225/basefrom
gh/kimishpatel/225/head
Open

Add xplat cxx_binary target for bench_sdpa#18705
kimishpatel wants to merge 14 commits intogh/kimishpatel/225/basefrom
gh/kimishpatel/225/head

Conversation

@kimishpatel
Copy link
Copy Markdown
Contributor

@kimishpatel kimishpatel commented Apr 6, 2026

Stack from ghstack (oldest at bottom):

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: D96044315

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 6, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18705

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 12 Pending, 3 Unrelated Failures

As of commit 0d7815a with merge base 1debeb6 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel
Copy link
Copy Markdown
Contributor Author

submitted by accident, not meant to land immedidately

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 23, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 371787365
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 24, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 372451169
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 27, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 373439502
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 28, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 374228874
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 29, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 374666324
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 30, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 375300140
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request Apr 30, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 375388935
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 1, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 376092494
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 5, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 377506496
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 5, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 377591903
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 5, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 377697714
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 5, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 377749269
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)

[ghstack-poisoned]
kimishpatel added a commit that referenced this pull request May 6, 2026
Pull Request resolved: #18705

Add non_fbcode_target cxx_binary so bench_sdpa can be built via the
xplat build path (e.g. for on-device testing). Wrap the existing
cpp_benchmark in fbcode_target to avoid name collision between the
fbcode benchmark target and the xplat binary target.
ghstack-source-id: 378132054
@exported-using-ghexport

Differential Revision: [D96044315](https://our.internmc.facebook.com/intern/diff/D96044315/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant