[ET-VK] Add Vulkan 1.0 compatibility for extension feature querying#17160
Merged
meta-codesync[bot] merged 3 commits intogh/SS-JIA/404/basefrom Feb 4, 2026
Merged
[ET-VK] Add Vulkan 1.0 compatibility for extension feature querying#17160meta-codesync[bot] merged 3 commits intogh/SS-JIA/404/basefrom
meta-codesync[bot] merged 3 commits intogh/SS-JIA/404/basefrom
Conversation
The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/) [ghstack-poisoned]
This was referenced Feb 3, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17160
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 9e59569 with merge base 593775b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
SS-JIA
pushed a commit
that referenced
this pull request
Feb 3, 2026
The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/) ghstack-source-id: 337901648 Pull Request resolved: #17160
This PR needs a
|
manuelcandales
approved these changes
Feb 3, 2026
… querying" The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/) cc manuelcandales digantdesai cbilgin [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Feb 3, 2026
Pull Request resolved: #17160 The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. ghstack-source-id: 337927970 @exported-using-ghexport Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/)
… querying" The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/) cc manuelcandales digantdesai cbilgin [ghstack-poisoned]
SS-JIA
pushed a commit
that referenced
this pull request
Feb 3, 2026
Pull Request resolved: #17160 The previous implementation used `vkGetPhysicalDeviceFeatures2` unconditionally, which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail to query extension features correctly. This change refactors PhysicalDevice to detect the API version at runtime and use the appropriate method: - Vulkan 1.0: Uses KHR extension functions (vkGetPhysicalDeviceFeatures2KHR) obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable - Vulkan 1.1+: Uses core vkGetPhysicalDeviceFeatures2 directly Also fixes a bug where shader_int_dot_product_properties was incorrectly chained into the features linked list instead of being queried separately via vkGetPhysicalDeviceProperties2. This PR was authored with Claude. ghstack-source-id: 337979631 @exported-using-ghexport Differential Revision: [D92171361](https://our.internmc.facebook.com/intern/diff/D92171361/)
205ac64
into
gh/SS-JIA/404/base
180 of 183 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The previous implementation used
vkGetPhysicalDeviceFeatures2unconditionally,which is only available in Vulkan 1.1+. Devices running Vulkan 1.0 would fail
to query extension features correctly.
This change refactors PhysicalDevice to detect the API version at runtime and
use the appropriate method:
obtained via vkGetInstanceProcAddr, with graceful fallback if unavailable
Also fixes a bug where shader_int_dot_product_properties was incorrectly
chained into the features linked list instead of being queried separately
via vkGetPhysicalDeviceProperties2.
This PR was authored with Claude.
Differential Revision: D92171361
cc @manuelcandales @digantdesai @cbilgin