-
Notifications
You must be signed in to change notification settings - Fork 810
Arm backend: Fix bug in dump_operator_distribution #16537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Fix bug in dump_operator_distribution #16537
Conversation
A previous change removed the delegated vs non-delegated table of aten operators when calling dump_operator_distribution. This change adds it back. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Ib1449fe92a3384f8964580282199e37c047c5def
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16537
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit dd43f7d with merge base 9ba1b5d ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge if ARM tests pass
I see
trunk / test-arm-backend-ethos-u (test_pytest_models_ethos_u85) / linux-job (push)
->
FAILED backends/arm/test/models/test_conformer.py::test_conformer_u85_INT - AssertionError: Output 0 does not match reference output.
It's probably some flaky tests so it might help to just rerun the test.
|
I still see after this was merged, did you retrigger a testrun it passed? https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=arm-backend https://github.com/pytorch/executorch/actions/runs/20918602350/job/60098198182 Wonder how flakey this test is and/or if there is something strange with this PR causing it. (seem strange that is should) |
|
Test passed on next commit in the HUD so it's random. |
A previous change removed the delegated vs non-delegated table of aten operators when calling dump_operator_distribution. This change adds it back.
cc @freddan80 @per @zingo @digantdesai