-
Notifications
You must be signed in to change notification settings - Fork 796
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Runtime (backend/executor/kernel) #16475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - Runtime (backend/executor/kernel) #16475
Conversation
…ackend/executor/kernel) Remove the EXECUTORCH_CLIENTS buck client list visibility gating from runtime targets outside of core. This replaces all visibility blocks containing @EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 2 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - runtime/backend targets - runtime/executor targets - runtime/kernel targets Differential Revision: [D89902033](https://our.internmc.facebook.com/intern/diff/D89902033/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16475
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 6b53657 with merge base 09b5bdb ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
… Runtime (backend/executor/kernel)" Remove the EXECUTORCH_CLIENTS buck client list visibility gating from runtime targets outside of core. This replaces all visibility blocks containing EXECUTORCH_CLIENTS with explicit PUBLIC visibility. This is part 2 of a multi-diff stack to remove visibility gating across all of executorch. This diff covers: - runtime/backend targets - runtime/executor targets - runtime/kernel targets Differential Revision: [D89902033](https://our.internmc.facebook.com/intern/diff/D89902033/) [ghstack-poisoned]
72542f7
into
gh/GregoryComer/168/base
…ackend/executor/kernel) (#16522) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #16475 by @GregoryComer ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/GregoryComer/167/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/GregoryComer/168/orig Differential Revision: [D89902033](https://our.internmc.facebook.com/intern/diff/D89902033/) @diff-train-skip-merge --------- Co-authored-by: Gregory Comer <[email protected]>
Stack from ghstack (oldest at bottom):
Remove the EXECUTORCH_CLIENTS buck client list visibility gating from runtime
targets outside of core. This replaces all visibility blocks containing
@EXECUTORCH_CLIENTS with explicit PUBLIC visibility.
This is part 2 of a multi-diff stack to remove visibility gating across all of executorch.
This diff covers:
Differential Revision: D89902033