Skip to content

Update tokenizer pin #16323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergennachin merged 3 commits into from
Jan 13, 2026
Merged

Update tokenizer pin #16323

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
625b2a3
Update tokenizer pin
mergennachin Dec 18, 2025
bf12149
Test with patch
mergennachin Jan 12, 2026
459c6dc
Update .buckconfig
mergennachin Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions extension/llm/runner/test/test_text_llm_runner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ class MockTokenizer : public ::tokenizers::Tokenizer {
decode,
(uint64_t, uint64_t),
(const));
MOCK_METHOD(
::tokenizers::Result<std::string>,
id_to_piece,
(uint64_t),
(const));
MOCK_METHOD(uint64_t, bos_tok, (), (const));
MOCK_METHOD(uint64_t, eos_tok, (), (const));
MOCK_METHOD(uint64_t, vocab_size, (), (const));
Expand Down Expand Up @@ -127,6 +132,10 @@ class RunnerTest : public Test {
return ::tokenizers::Result<std::string>("token");
});

ON_CALL(*tokenizer, id_to_piece).WillByDefault([](uint64_t) {
return ::tokenizers::Result<std::string>("piece");
});

ON_CALL(*tokenizer, bos_tok()).WillByDefault(Return(1));
ON_CALL(*tokenizer, eos_tok()).WillByDefault(Return(2));
ON_CALL(*tokenizer, vocab_size()).WillByDefault(Return(100));
Expand Down
2 changes: 1 addition & 1 deletion extension/llm/tokenizers
Open in desktop
Submodule tokenizers updated 26 files
+208 −0 BUCK
+0 −5 TARGETS
+2 −0 include/pytorch/tokenizers/bpe_tokenizer_base.h
+2 −0 include/pytorch/tokenizers/llama2c_tokenizer.h
+2 −0 include/pytorch/tokenizers/sentencepiece.h
+15 −0 include/pytorch/tokenizers/tokenizer.h
+2 −1 pyproject.toml
+26 −0 pytorch_tokenizers/BUCK
+15 −0 pytorch_tokenizers/tools/llama2c/BUCK
+2 −1 setup.py
+18 −0 src/bpe_tokenizer_base.cpp
+25 −3 src/hf_tokenizer.cpp
+5 −0 src/llama2c_tokenizer.cpp
+11 −0 src/sentencepiece.cpp
+0 −218 targets.bzl
+70 −0 test/BUCK
+ − test/resources/test_llama2c_tokenizer.bin
+2 −6 test/targets.bzl
+253 −0 test/test_hf_tokenizer.cpp
+43 −6 test/test_llama2c_tokenizer.cpp
+36 −0 test/test_sentencepiece.cpp
+32 −0 test/test_tekken.cpp
+29 −0 test/test_tiktoken.cpp
+26 −0 third-party/BUCK
+0 −5 third-party/TARGETS
+0 −17 third-party/targets.bzl
Loading