-
Notifications
You must be signed in to change notification settings - Fork 732
[Executorch][llama] Split main in lib + binary #15919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/kimishpatel/215/base
Are you sure you want to change the base?
Conversation
Main reason to do so is to allow internal benchmarking binary to link against main_lib Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15919
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 947e62e with merge base aff5086 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Main reason to do so is to allow internal benchmarking binary to link against main_lib Differential Revision: [D87547090](https://our.internmc.facebook.com/intern/diff/D87547090/) ghstack-source-id: 324690959 Pull Request resolved: #15919
This PR needs a
|
| runtime.cxx_binary( | ||
| name = "main" + aten_suffix, | ||
| runtime.cxx_library( | ||
| name = "main" + aten_suffix + "_lib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "main_lib" + aten_suffix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
| name = "main" + aten_suffix, | ||
| srcs = [], | ||
| deps = [ | ||
| ":main" + aten_suffix + "_lib", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, ":main_lib" + aten_suffix,
Stack from ghstack (oldest at bottom):
Main reason to do so is to allow internal benchmarking binary to link against main_lib
Differential Revision: D87547090