[ET-VK][Ops] dequantize_per_channel reference impl and testing#12206

Merged

facebook-github-bot merged 9 commits intogh/ahmtox/34/basefrom

gh/ahmtox/34/head

Jul 14, 2025

Contributor

ahmtox commented Jul 3, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: D77746138


          [ET-VK][Ops] dequantize_per_channel reference impl and testing

4d697b7

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

ahmtox requested review from JacobSzwejbka and SS-JIA as code owners

July 3, 2025 18:17

pytorch-bot bot commented Jul 3, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12206

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b7afa2a with merge base 1540659 ():

NEW FAILURE - The following job has failed:

pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t dc9efbc469747a5aa3660a01d9fab642c89941d302232beb6d6d175603180208 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 3, 2025

[ET-VK][Ops] aligning Q/DQ/CQP op inputs with ATen impl #12199

Merged

[ET-VK][ez][Ops] registering Q/DQ/CQP ops and specifying optimal storage #12200

Merged

[ET-VK][ez] enabling fp64->fp32 converison for vulkan compatibility #12201

Merged

[ET-VK] lowering ExecuTorch tensor dtype for Vulkan tensor dtype to enable 64bit #12202

Closed

[ET] correcting cpu ref quantize_per_channel logic to align with ATen #12203

Merged

[ET-VK][Ops] quantize_per_channel reference impl and testing #12204

Merged

[ET-VK][Ops] quantize_per_channel shaders and impl #12205

Merged

[ET-VK][Ops] dequantize_per_channel shaders and impl #12207

Merged

[ET-VK][Ops] quantize_per_tensor.tensor variant #12208

Merged

[ET-VK][Ops] dequantize_per_tensor.tensor variant #12209

Merged

[ET-VK][testing] Q/DQ/CQP op comprehensive delegate dynamic quantization testing #12210

Merged

github-actions bot commented Jul 3, 2025

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jul 3, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138

facebook-github-bot added the fb-exported label


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

84e097f

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 3, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

567e5d2

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 7, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

7adb108

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

ahmtox mentioned this pull request

[ET-VK][Ops] affine quantization operators registration #12369

Merged

Contributor

facebook-github-bot commented Jul 10, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138

lucylq approved these changes

View reviewed changes

Contributor

lucylq left a comment

LGTM on the executorch/extension side, thank you for extending the functionality to include const ref optionals and adding tests coverage.


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

132fa03

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 11, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

8b1404c

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 11, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

01361a4

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 11, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

a253b4d

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 11, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138


          Update on "[ET-VK][Ops] dequantize_per_channel reference impl and tes…

b7afa2a

…ting"

# Context

In order to properly enable dynamic quantization, we create the dequantize_per_channel operator as its seemingly useful to have for the pipeline.

# Changes

This creates the wrapper for the cpu reference implementation, and also a dummy reference implementation I created just to test against it.

Differential Revision: [D77746138](https://our.internmc.facebook.com/intern/diff/D77746138/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Jul 14, 2025

This pull request was exported from Phabricator. Differential Revision: D77746138

facebook-github-bot merged commit 140180a into gh/ahmtox/34/base

98 of 100 checks passed

facebook-github-bot deleted the gh/ahmtox/34/head branch

July 14, 2025 14:58

facebook-github-bot temporarily deployed to cherry-pick-bot

July 14, 2025 14:58

— with

GitHub Actions Inactive

pytorchbot mentioned this pull request

[ET-VK][Ops] dequantize_per_channel reference impl and testing #12434

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported