[4/N] Add backend options map #11462

cccclai · 2025-06-06T23:49:36Z

Stack from ghstack (oldest at bottom):

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend.
@exported-using-ghexport

Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

pytorch-bot · 2025-06-06T23:49:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11462

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit 875fdc4 with merge base f7cc72f ():

NEW FAILURES - The following jobs have failed:

Lint / lintrunner / linux-job (gh)
RuntimeError: Command docker exec -t ec0f25e21fa6ac4e4ac8df53c949c5bea61f2a3ae1536e41a0dd49f83210fb99 /exec failed with exit code 127
pull / unittest-buck / linux / linux-job (gh)
buck-out/v2/gen/root/904931f735703749/runtime/backend/__backend_options_map__/buck-headers/executorch/runtime/backend/backend_options_map.h:48:16: error: no viable conversion from returned value of type 'const Span<executorch::runtime::BackendOption>' to function return type 'Span<const executorch::runtime::BackendOption>'
pull / unittest-buck / macos / macos-job (gh)
buck-out/v2/gen/root/200212f73efcd57d/runtime/backend/__backend_options_map__/buck-headers/executorch/runtime/backend/backend_options_map.h:48:16: error: no viable conversion from returned value of type 'const Span<BackendOption>' to function return type 'Span<const BackendOption>'
pull / unittest-editable / macos / macos-job (gh)
backends/xnnpack/test/ops/test_conv1d.py::TestConv1d::test_qs8_conv1d_batchnorm_seq

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
.ci/scripts/tests/test_gather_benchmark_configs.py::TestGatehrBenchmarkConfigs::test_generate_compatible_configs_quantized_llama_model

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-06-06T23:50:11Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot · 2025-06-06T23:50:33Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-10T18:40:27Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-12T21:36:58Z

This pull request was exported from Phabricator. Differential Revision: D76149466

runtime/backend/backend_options.h

kimishpatel · 2025-06-13T03:06:35Z

runtime/backend/backend_options.h

+    return executorch::runtime::ArrayRef<BackendOption>(options_, size_);
+  }


is this method needed?

kimishpatel · 2025-06-13T03:07:09Z

runtime/backend/backend_options_map.h

+};
+
+template <size_t MaxBackends>
+class BackendOptionsMap {


why do we need this?

This is to manage the mapping between backend_name and backend options. Like
{
"XNNPACK": ["profile": true, "thread": 4],
"QNN": ["power": "high"],
}

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

Pull Request resolved: #11462 This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. ghstack-source-id: 290371659 @exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/)

facebook-github-bot · 2025-06-13T22:31:17Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T16:13:30Z

This pull request was exported from Phabricator. Differential Revision: D76149466

This is to manage the backend <-> BackendOptions map. Users will create the bakcend options map, and ET runtime will read the backend name, and dispatch the list of backend options to each backend. exported-using-ghexport Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466/) Differential Revision: [D76149466](https://our.internmc.facebook.com/intern/diff/D76149466) [ghstack-poisoned]

facebook-github-bot · 2025-06-17T18:23:42Z

This pull request was exported from Phabricator. Differential Revision: D76149466

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025

This was referenced Jun 6, 2025

[1/N] Add BackendOptions class #11389

Open

[2/N] Add update context #11390

Open

[3/N] Add update function in backend interface #11391

Open

[5/N] Add update in method #11463

Open

facebook-github-bot added the fb-exported label Jun 6, 2025

This was referenced Jun 10, 2025

[6/N] Add update in module #11533

Open

[7/N] Add sugar syntax for module.update #11534

Open

kimishpatel reviewed Jun 13, 2025

View reviewed changes

runtime/backend/backend_options.h Outdated Show resolved Hide resolved

kimishpatel reviewed Jun 13, 2025

View reviewed changes

This was referenced Jun 17, 2025

Support Span to construct from a single element similar to ArrayRef #11757

Merged

Add get_option/set_option APIs #11758

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[4/N] Add backend options map #11462

[4/N] Add backend options map #11462

Uh oh!

cccclai commented Jun 6, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

kimishpatel Jun 13, 2025

Uh oh!

cccclai Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

Uh oh!

		return executorch::runtime::ArrayRef<BackendOption>(options_, size_);
		}

[4/N] Add backend options map #11462

Are you sure you want to change the base?

[4/N] Add backend options map #11462

Uh oh!

Conversation

cccclai commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11462

❌ 4 New Failures, 2 Unrelated Failures

Uh oh!

github-actions bot commented Jun 6, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jun 6, 2025

Uh oh!

facebook-github-bot commented Jun 10, 2025

Uh oh!

facebook-github-bot commented Jun 12, 2025

Uh oh!

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

kimishpatel Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

cccclai Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 13, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

facebook-github-bot commented Jun 17, 2025

Uh oh!

Uh oh!

cccclai commented Jun 6, 2025 •

edited

Loading

pytorch-bot bot commented Jun 6, 2025 •

edited

Loading

This PR needs a `release notes:` label