Skip to content

Commit e6d619d

Browse files
committed
Address PR #19533 review #5: dedupe define_common_targets load
Remove the duplicate load(":targets.bzl", "define_common_targets") and its redundant comment in chat_template/BUCK (artifact of the fbcode/xplat TARGETS merge). The single top load covers both non_fbcode_target and fbcode_target; defined targets are unchanged.
1 parent 81b9210 commit e6d619d

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

  • extension/llm/chat_template

extension/llm/chat_template/BUCK

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,4 @@ non_fbcode_target(_kind = define_common_targets,)
1010

1111
# !!!! fbcode/executorch/extension/llm/chat_template/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!
1212

13-
# Any targets that should be shared between fbcode and xplat must be defined in
14-
# targets.bzl. This file can contain fbcode-only targets.
15-
16-
load(":targets.bzl", "define_common_targets")
17-
1813
fbcode_target(_kind = define_common_targets,)

0 commit comments

Comments
 (0)