Commit 81b9210
committed
Address PR #19533 review: guard test on jinja2cpp; document empty tools default
- test/CMakeLists.txt: exclude test_jinja_chat_formatter.cpp from the test
binary when jinja2cpp isn't built (mirrors the runner CMake guard), so
building tests without the chat_template subdir doesn't fail to link with
undefined JinjaChatFormatter symbols (review #4).
- jinja_chat_formatter.cpp: document that the empty `tools` list is
intentionally falsy so the normalized no-tools template path renders
(review #1).1 parent 7c3280c commit 81b9210
2 files changed
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
359 | 359 | | |
360 | 360 | | |
361 | 361 | | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
362 | 367 | | |
363 | 368 | | |
364 | 369 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| |||
0 commit comments