Skip to content

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 30, 2025

Add a missing part in #4942 .
I also fix another aarch64 issue on PyTorch CI:

/var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/./Utils.h:26:10: fatal error: arm_neon_sve_bridge.h: No such file or directory
   26 | #include <arm_neon_sve_bridge.h> // @manual
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

ARM documentation says:

SVE and SVE2 feature paths in libaom, libvpx, and x265 require the intrinsics declared in arm_neon_sve_bridge.h. This header file is available in the following releases:

Clang 17 and later.
GCC 14 and later.

Signed-off-by: Yuanyuan Chen <[email protected]>
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 84b96c5
🔍 Latest deploy log https://app.netlify.com/projects/pytorch-fbgemm-docs/deploys/68dc6ca80f53090008d64d56
😎 Deploy Preview https://deploy-preview-4948--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla bot added the cla signed label Sep 30, 2025
@facebook-github-bot
Copy link
Contributor

@q10 has imported this pull request. If you are a Meta employee, you can view this in D83578552.

@q10
Copy link
Contributor

q10 commented Sep 30, 2025

Looks like we're running into

Error: unknown architecture `-march=armv8.2-a+fp16fml'

Signed-off-by: Yuanyuan Chen <[email protected]>
@cyyever
Copy link
Contributor Author

cyyever commented Sep 30, 2025

@q10 fixed

@cyyever cyyever changed the title Use fbgemm_fml_flags Use fbgemm_fml_flags and add fbgemm_sve guard Sep 30, 2025
@cyyever
Copy link
Contributor Author

cyyever commented Oct 1, 2025

@q10 Unrelated failure

@facebook-github-bot
Copy link
Contributor

@q10 merged this pull request in 56ecc59.

@cyyever cyyever deleted the fbgemm_fml_flags branch October 2, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants