more hipify v2 fixes (#4854) #4947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 similar comment
q10
force-pushed
the
export-D83519493
branch
from
af4c58a to
8e6c60c
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
force-pushed
the
export-D83519493
branch
from
8e6c60c to
a6c4937
Compare
q10
force-pushed
the
export-D83519493
branch
from
a6c4937 to
0419fe3
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
force-pushed
the
export-D83519493
branch
from
0419fe3 to
660a01a
Compare
q10
force-pushed
the
export-D83519493
branch
from
660a01a to
3fd858e
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
force-pushed
the
export-D83519493
branch
from
3fd858e to
b193aea
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 30, 2025
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
force-pushed
the
export-D83519493
branch
from
b193aea to
99eb107
Compare
Summary: Pull Request resolved: pytorch#4947 X-link: facebookresearch/FBGEMM#1969 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Differential Revision: D83519493 Pulled By: q10
q10
force-pushed
the
export-D83519493
branch
from
99eb107 to
761a939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1969
Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs.
Differential Revision: D83519493
Pulled By: q10