more hipify v2 fixes (#4854) #4921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
1627d3b to
438c2c0
Compare
q10
force-pushed
the
export-D82186865
branch
from
438c2c0 to
dbd465a
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
dbd465a to
5977f97
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
5977f97 to
220a1e3
Compare
q10
force-pushed
the
export-D82186865
branch
from
220a1e3 to
aeff284
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 24, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
aeff284 to
4a11016
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 29, 2025
Summary: X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 29, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
4a11016 to
21fbd82
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 29, 2025
Summary: X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
21fbd82 to
3d91333
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 29, 2025
Summary: Pull Request resolved: pytorch#4921 X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Pull Request resolved: pytorch#4854 Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
3d91333 to
71448c5
Compare
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Sep 29, 2025
Summary: X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
71448c5 to
b8ea1b2
Compare
Summary: X-link: facebookresearch/FBGEMM#1898 Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs. Reviewed By: atalman Differential Revision: D82186865 Pulled By: q10
q10
force-pushed
the
export-D82186865
branch
from
b8ea1b2 to
1b8aec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1898
Prior to the pytorch hipify v2 PR is landed, additional fixes are needed for the experimental gen_ai HIP sources. The fbgemm_gpu *.hip sources do not undergo additional hipify steps and they were written to assume pytorch's hipify v1 interfaces. Some small changes are necessary to make the sources more flexible to either hipify v1 or v2 torch APIs.
Reviewed By: atalman
Differential Revision: D82186865
Pulled By: q10