[fbgemm] Modularize FBGEMM CMake Target Definitions, pt 1 #4509
+306
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cyyever
reviewed
Jul 17, 2025
CMakeLists.txt
Outdated
| SRCS | ||
| ${FBGEMM_AVX512_SRCS} | ||
| ${FBGEMM_AVX512_INLINE_SRCS} | ||
| INCLUDE_DIRS |
There was a problem hiding this comment.
INCLUDE_DIRS are not required, because the target can link to the dependencies, and their include paths will be available to FBGEMM. Modern CMake targets shouldn't use include paths.
q10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpp_library()CMake function and redefine existing FBGEMM targets using this function to simplify CMake configuration